feat(js): Update profiling pages to avoid unnecessary nesting #13352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 6.62kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Member
|
I would either rename the pages to have solid redirects or simply add hardcoded redirects for the guides that changed (e.g. https://docs.sentry.io/platforms/javascript/profiling/browser-profiling/ does have quite some traffic on plausible but would result in a 404 with this change) |
For browser/node SDKs, we do not need to have a higher-level "Profiling" page that is empty with just a single sub-page "Browser Profiling" / "Node Profiling". Instead, now those will simply have a single "Profiling" page with the respective content. Only meta SDKs have a landing page with sub pages.
mydea
force-pushed
the
fn/js-profiling-docs
branch
from
fd2114d to
2b81fd7
Compare
Member
Author
Makes sense - I renamed them to |
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
* feat(js): Update profiling pages to avoid unnecessary nesting For browser/node SDKs, we do not need to have a higher-level "Profiling" page that is empty with just a single sub-page "Browser Profiling" / "Node Profiling". Instead, now those will simply have a single "Profiling" page with the respective content. Only meta SDKs have a landing page with sub pages. * rename to browser * rename node * add redirects * avoid already renaming this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For browser/node SDKs, we do not need to have a higher-level "Profiling" page that is empty with just a single sub-page "Browser Profiling" / "Node Profiling".
Instead, now those will simply have a single "Profiling" page with the respective content. Only meta SDKs have a landing page with sub pages.
Note that this may break some links, e.g. when somebody used to link to
express/profiling/node-profiling🤔 We'd have to manually add a redirect for every single guide here, not sure if we want this? 😬 as we cannot blanket redirect e.g./guides/:guide/profiling/profiling-nodebecause this page does exist in some places.Or alternatively we rename the new pages to something else (e.g.
profiling/nodeandprofiling/browser), then we can blanket-redirect again - WDYT?