Skip to content

fix(style): Ensure scrollbar is consistent #13354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(style): Ensure scrollbar is consistent #13354

merged 1 commit into from
Apr 11, 2025

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 11, 2025

This removes the "hack" to only show the scrollbar on hover. Which is nice in theory, but got really jumpy now.
IMHO it is ok to just always show this, def. better than the current jumpy version!

I also aligned the padding on top so it is consistent around for the sidebar.

Previously

Screen.Recording.2025-04-11.at.12.27.13.mov

With this change

Screen.Recording.2025-04-11.at.12.26.00.mov

@mydea mydea requested review from a team, a-hariti, chargome and stephanie-anderson April 11, 2025 10:28
@mydea mydea self-assigned this Apr 11, 2025
@vercel
Copy link

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 10:41am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 10:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 11, 2025 10:41am

@codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 108 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB 16 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -124 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
2065.js 25 bytes 81.98kB 0.03%

Files in 2065.js:

  • ./src/components/sidebar/style.module.scss → Total Size: 236 bytes

  • ./src/components/sidebar/index.tsx → Total Size: 5.18kB

  • ./src/components/sidebar/style.module.scss → Total Size: 236 bytes

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/css/*.css -118 bytes 14.05kB -0.83%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/mzYC-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/mzYC-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/6lQX-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/6lQX-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

chargome
chargome approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 ✨

@mydea mydea merged commit ff2ad87 into master Apr 11, 2025
13 checks passed
@mydea mydea deleted the fn/fix-sidebar-scroll branch April 11, 2025 12:27
@chargome chargome mentioned this pull request Apr 22, 2025
Merged
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
@mydea @bitsandfoxes
fix(style): Ensure scrollbar is consistent (#13354)
94fa7fd
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-hariti a-hariti a-hariti approved these changes

@chargome chargome chargome approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @a-hariti @chargome