fix(style): Add padding for dev docs sidebar #13463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 6 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
mydea
reviewed
Apr 22, 2025
| }; | ||
| return ( | ||
| <aside className={styles.sidebar}> | ||
| <aside className={`${styles.sidebar} py-3`}> |
Member
There was a problem hiding this comment.
can this not just be
Suggested change
| <aside className={`${styles.sidebar} py-3`}> | |
| <aside className={`${styles.sidebar} p-3`}> |
or does this need to be spread out like this?
Member
Author
There was a problem hiding this comment.
I simplified it by just moving the padding altogether to the aside but a a horizontal padding of 6 would be too much
mydea
approved these changes
Apr 22, 2025
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simply adds some padding to the dev docs sidebar that got lost in #13354