Skip to content

fix(style): Add padding for dev docs sidebar #13463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

fix(style): Add padding for dev docs sidebar #13463

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5add10c
re-add padding for dev docs sidebar
chargome Apr 22, 2025
808beea
simplify
chargome Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/sidebar/developDocsSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export function DevelopDocsSidebar({
return toTree(apiNodes);
};
return (
<aside className={styles.sidebar}>
<aside className={`${styles.sidebar} py-3`}>
Copy link
Member

@mydea mydea Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this not just be

Suggested change
<aside className={`${styles.sidebar} py-3`}>
<aside className={`${styles.sidebar} p-3`}>

or does this need to be spread out like this?

Copy link
Member Author

@chargome chargome Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified it by just moving the padding altogether to the aside but a a horizontal padding of 6 would be too much

<input type="checkbox" id={sidebarToggleId} className="hidden" />
<style>{':root { --sidebar-width: 300px; }'}</style>
<div className="md:flex flex-col items-stretch">
<div className="md:flex flex-col items-stretch px-3">
<div className={styles.toc}>
<ul data-sidebar-tree>
{devDocsMenuItems.map(({root, title}) => (
Expand Down
Loading