-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ci(caching): Add .eslintcache and .next/cache to cache #14252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves CI performance by caching ESLint and Next.js build artifacts, and cleans up an obsolete lint script.
- Removed the deprecated
lint:docsscript frompackage.json. - Extended GitHub Actions caching to include
.next/cacheand.eslintcache. - Updated the ESLint fix step to leverage ESLint’s
--cacheoption.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed lint:docs script to drop outdated documentation checks. |
| .github/workflows/test.yml | Added .next/cache & .eslintcache to cache paths; updated fix step. |
| .github/workflows/lint-404s.yml | Added .next/cache & .eslintcache to cache paths. |
Comments suppressed due to low confidence (4)
package.json:27
- [nitpick] Removed the
lint:docsscript; ensure any references (e.g., in README or CI docs) are updated or removed to prevent confusion.
"lint:ts": "tsc --skipLibCheck",
.github/workflows/test.yml:48
- Yarn may interpret
--cacheas a Yarn flag rather than passing it to ESLint; consider usingyarn lint:eslint:fix -- --cacheor updating the npm script to include--cacheby default.
- run: yarn lint:eslint:fix --cache
.github/workflows/lint-404s.yml:38
- [nitpick] This job doesn’t run ESLint, so caching
.eslintcachewon’t provide benefits; remove it to reduce unnecessary cache size.
${{ github.workspace }}/.eslintcache
.github/workflows/lint-404s.yml:39
- Add a
restore-keyssection here (as in other workflows) to improve cache hit rate when the lockfile changes.
key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
No description provided.