Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jul 3, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 11:44am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 11:44am

@codecov
Copy link

codecov bot commented Jul 3, 2025

Bundle Report

Changes will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.8MB 381 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.8MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json 130 bytes 692.74kB 0.02%
../app/platform-redirect/page.js.nft.json 130 bytes 692.66kB 0.02%
../app/sitemap.xml/route.js.nft.json 130 bytes 690.63kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 415.85kB -0.0%
static/eJyQvs_TBvBgQ3LgfFfcC/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/eJyQvs_TBvBgQ3LgfFfcC/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/YuCC3bmRI2Wt72ROPriwx/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/YuCC3bmRI2Wt72ROPriwx/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves CI performance by caching ESLint and Next.js build artifacts, and cleans up an obsolete lint script.

  • Removed the deprecated lint:docs script from package.json.
  • Extended GitHub Actions caching to include .next/cache and .eslintcache.
  • Updated the ESLint fix step to leverage ESLint’s --cache option.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Removed lint:docs script to drop outdated documentation checks.
.github/workflows/test.yml Added .next/cache & .eslintcache to cache paths; updated fix step.
.github/workflows/lint-404s.yml Added .next/cache & .eslintcache to cache paths.
Comments suppressed due to low confidence (4)

package.json:27

  • [nitpick] Removed the lint:docs script; ensure any references (e.g., in README or CI docs) are updated or removed to prevent confusion.
    "lint:ts": "tsc --skipLibCheck",

.github/workflows/test.yml:48

  • Yarn may interpret --cache as a Yarn flag rather than passing it to ESLint; consider using yarn lint:eslint:fix -- --cache or updating the npm script to include --cache by default.
      - run: yarn lint:eslint:fix --cache

.github/workflows/lint-404s.yml:38

  • [nitpick] This job doesn’t run ESLint, so caching .eslintcache won’t provide benefits; remove it to reduce unnecessary cache size.
            ${{ github.workspace }}/.eslintcache

.github/workflows/lint-404s.yml:39

  • Add a restore-keys section here (as in other workflows) to improve cache hit rate when the lockfile changes.
          key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}

@BYK BYK merged commit 7f4fd89 into master Jul 3, 2025
15 checks passed
@BYK BYK deleted the byk/ci/next-js-cache-gha branch July 3, 2025 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants