Skip to content

ci(caching): Add .eslintcache and .next/cache to cache #14252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 2 commits into from
Jul 3, 2025
Merged

ci(caching): Add .eslintcache and .next/cache to cache #14252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d920c2c
ci(caching): Add .eslintcache and .next/cache to cache
BYK Jul 3, 2025
1bb6cd8
add missing restore-keys
BYK Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/lint-404s.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,13 @@ jobs:
- uses: actions/cache@v4
id: cache
with:
path: ${{ github.workspace }}/node_modules
path: |
${{ github.workspace }}/node_modules
${{ github.workspace }}/.next/cache
${{ github.workspace }}/.eslintcache
key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
node-${{ runner.os }}-

- run: yarn install --frozen-lockfile
if: steps.cache.outputs.cache-hit != 'true'
Expand Down
19 changes: 15 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,23 @@ jobs:
- uses: actions/cache@v4
id: cache
with:
path: ${{ github.workspace }}/node_modules
path: |
${{ github.workspace }}/node_modules
${{ github.workspace }}/.next/cache
${{ github.workspace }}/.eslintcache
key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
node-${{ runner.os }}-

- run: yarn install --frozen-lockfile
if: steps.cache.outputs.cache-hit != 'true'

# Additional checks
- run: yarn lint:ts
- run: yarn lint:docs

# Run automatic fixes (run prettier apart from eslint to also fix mdx files)
- run: yarn lint:prettier:fix
- run: yarn lint:eslint:fix
- run: yarn lint:eslint:fix --cache

# Check (and error) for dirty working tree for forks
# Reason being we need a different token to auto commit changes and
Expand Down Expand Up @@ -69,8 +74,14 @@ jobs:
- uses: actions/cache@v4
id: cache
with:
path: ${{ github.workspace }}/node_modules
path: |
${{ github.workspace }}/node_modules
${{ github.workspace }}/.next/cache
${{ github.workspace }}/.eslintcache
key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
node-${{ runner.os }}-

- run: yarn install --frozen-lockfile
if: steps.cache.outputs.cache-hit != 'true'
- name: Run Tests
Expand Down
6 changes: 0 additions & 6 deletions bin/lint-docs.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"start": "next start",
"lint": "next lint",
"lint:ts": "tsc --skipLibCheck",
"lint:docs": "bin/lint-docs.ts",
"lint:eslint": "eslint \"{src,app,scripts}/**/*.{ts,tsx,js,jsx}\"",
"lint:eslint:fix": "eslint --fix \"{src,app,scripts}/**/*.{ts,tsx,js,jsx}\"",
"lint:prettier": "prettier --check \"./{src,app,scripts}/**/*.{md,mdx,ts,tsx,js,jsx,mjs}\"",
Expand Down
Loading