Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 22, 2025

DESCRIBE YOUR PR

This PR adds documentation for the new reportPageLoaded() API which is coupled to the new enableReportPageLoaded option in the browserTracingIntegration. Both have been added via getsentry/sentry-javascript#17724 and released in 10.13.0.

Also added a new availableSince prop to the SdkApi component.

closes https://linear.app/getsentry/issue/FE-607/docs-for-reportpageloaded

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 24, 2025 0:07am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 24, 2025 0:07am

@Lms24 Lms24 requested review from a team, chargome and andreiborza and removed request for a team September 22, 2025 14:10
@Lms24 Lms24 self-assigned this Sep 22, 2025
Copy link

linear bot commented Sep 22, 2025

Copy link

codecov bot commented Sep 22, 2025

Bundle Report

Changes will increase total bundle size by 10.03kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.86MB 10.04kB (0.08%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/uzfwz1wCWWtlqmv7tNQAU/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/uzfwz1wCWWtlqmv7tNQAU/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/aLIQNr73OQQ-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/aLIQNr73OQQ-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 3.31kB 824.15kB 0.4%
../app/platform-redirect/page.js.nft.json 3.31kB 824.06kB 0.4%
../app/sitemap.xml/route.js.nft.json 3.31kB 821.29kB 0.4%
../app/[[...path]]/page.js 119 bytes 612.17kB 0.02%

Files in ../app/[[...path]]/page.js:

  • ./src/components/sdkApi.tsx → Total Size: 6.88kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 119 bytes 3.36MB 0.0%

Signals to the Sentry SDK that the initial page was fully loaded.
Requires the <PlatformLink to="/tracing/instrumentation/automatic-instrumentation/#enableReportPageLoaded">`enableReportPageLoaded` option</PlatformLink> in `browserTracingIntegration` to
be set to `true`. Once called, the SDK ends the pageload span explicitly.
By default, the SDK takes care of ending the pageload span automatically, based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, the SDK takes care of ending the pageload span automatically, based on
based on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully sure I get this suggestion correctly because the goal here was to explain what the SDK does by default (i.e. when reportPageLoaded() is not used). I think though it's better to join this sentence with the paragraph below instead (see #15006 (comment))

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs portion of this looks good!

@Lms24 Lms24 merged commit f626de5 into master Sep 25, 2025
15 checks passed
@Lms24 Lms24 deleted the lms/feat-js-browser-reportPageLoaded branch September 25, 2025 08:11
Lms24 added a commit that referenced this pull request Sep 26, 2025
…15007)

<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR

Adds documentation for `Sentry. setActiveSpanInBrowser(span)` which is
added via getsentry/sentry-javascript#17714. To
be merged only after the feature was released. This is still based on
#15006 because I need the `availableSince` prop on the `SdkApi`
component.

closes https://linear.app/getsentry/issue/FE-608/docs-for-setspanactive

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [ ] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)

---------

Co-authored-by: Shannon Anahata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants