Skip to content

fix(billing): Correct billing-related actions for roles #15370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2025
+9 −6
Merged

fix(billing): Correct billing-related actions for roles #15370

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c9a566
fix(billing): Correct billing-related actions for roles
isabellaenriquez Oct 31, 2025
2661847
fix formatting
isabellaenriquez Oct 31, 2025
757fd72
clarify + fix outdated
isabellaenriquez Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/organization/membership/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ Organization-level roles enable broad access to the entire organization, as desc

| **Action** | **Billing** | **Member** | **Admin** | **Manager** | **Owner** |
| ------------------------------------------------------------------------------- | ----------- | ---------- | --------- | ----------- | --------- |
| Can see and edit billing information and subscription details | ✓ | | | | ✓ |
| Can edit billing information and subscription details | ✓ | | | | ✓ |
| Can see subscription details | ✓ | ✓ | ✓ | ✓ | ✓ |
Copy link

@sentry sentry bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: docs/organization/membership/index.mdx states all roles can see subscription details, contradicting other docs limiting access to Billing/Owner roles.
Severity: HIGH | Confidence: 0.95

🔍 Detailed Analysis

The pull request modifies docs/organization/membership/index.mdx to state that all organization roles (Billing, Member, Admin, Manager, Owner) can see subscription details. This contradicts existing documentation in docs/pricing/index.mdx, docs/pricing/legacy-pricing.mdx, docs/pricing/quotas/manage-attachments-quota.mdx, and docs/product/alerts/notifications/index.mdx, which consistently state that only Billing or Owner-level users have this permission. This inconsistency will confuse users who expect to access subscription details based on the membership table but are denied access in practice.

💡 Suggested Fix

Either revert the change in docs/organization/membership/index.mdx to reflect Billing/Owner-only access, or update all other relevant documentation files to align with the new statement that all roles can see subscription details.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/organization/membership/index.mdx#L37

Potential issue: The pull request modifies `docs/organization/membership/index.mdx` to
state that all organization roles (Billing, Member, Admin, Manager, Owner) can see
subscription details. This contradicts existing documentation in
`docs/pricing/index.mdx`, `docs/pricing/legacy-pricing.mdx`,
`docs/pricing/quotas/manage-attachments-quota.mdx`, and
`docs/product/alerts/notifications/index.mdx`, which consistently state that only
Billing or Owner-level users have this permission. This inconsistency will confuse users
who expect to access subscription details based on the membership table but are denied
access in practice.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member Author

@isabellaenriquez isabellaenriquez Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the other pages, this shouldn't contradict any of them since those pages refer to editing actions, which remains unchanged in terms of perms

| Can see and edit legal and compliance details | ✓ | | | | ✓ |
| Can view and act on issues (such as assigning and resolving) | | ✓ | ✓ | ✓ | ✓ |
| Can join and leave existing teams | | ✓ | ✓ | ✓ | ✓ |
Expand Down
Loading