-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(billing): Correct billing-related actions for roles #15370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.13kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| | ------------------------------------------------------------------------------- | ----------- | ---------- | --------- | ----------- | --------- | | ||
| | Can see and edit billing information and subscription details | ✓ | | | | ✓ | | ||
| | Can edit billing information and subscription details | ✓ | | | | ✓ | | ||
| | Can see subscription details | ✓ | ✓ | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: docs/organization/membership/index.mdx states all roles can see subscription details, contradicting other docs limiting access to Billing/Owner roles.
Severity: HIGH | Confidence: 0.95
🔍 Detailed Analysis
The pull request modifies docs/organization/membership/index.mdx to state that all organization roles (Billing, Member, Admin, Manager, Owner) can see subscription details. This contradicts existing documentation in docs/pricing/index.mdx, docs/pricing/legacy-pricing.mdx, docs/pricing/quotas/manage-attachments-quota.mdx, and docs/product/alerts/notifications/index.mdx, which consistently state that only Billing or Owner-level users have this permission. This inconsistency will confuse users who expect to access subscription details based on the membership table but are denied access in practice.
💡 Suggested Fix
Either revert the change in docs/organization/membership/index.mdx to reflect Billing/Owner-only access, or update all other relevant documentation files to align with the new statement that all roles can see subscription details.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/organization/membership/index.mdx#L37
Potential issue: The pull request modifies `docs/organization/membership/index.mdx` to
state that all organization roles (Billing, Member, Admin, Manager, Owner) can see
subscription details. This contradicts existing documentation in
`docs/pricing/index.mdx`, `docs/pricing/legacy-pricing.mdx`,
`docs/pricing/quotas/manage-attachments-quota.mdx`, and
`docs/product/alerts/notifications/index.mdx`, which consistently state that only
Billing or Owner-level users have this permission. This inconsistency will confuse users
who expect to access subscription details based on the membership table but are denied
access in practice.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked the other pages, this shouldn't contradict any of them since those pages refer to editing actions, which remains unchanged in terms of perms
DESCRIBE YOUR PR
Corrects membership role docs related to billing actions.

IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: