Skip to content

Conversation

@isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Oct 31, 2025

DESCRIBE YOUR PR

Corrects membership role docs related to billing actions.
Screenshot 2025-10-31 at 3 31 37 PM

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@linear
Copy link

linear bot commented Oct 31, 2025

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 31, 2025 7:54pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 31, 2025 7:54pm

@codecov
Copy link

codecov bot commented Oct 31, 2025

Bundle Report

Changes will increase total bundle size by 1.13kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.84MB 1.13kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 381 bytes 846.49kB 0.05%
../app/platform-redirect/page.js.nft.json 381 bytes 846.4kB 0.05%
../app/sitemap.xml/route.js.nft.json 381 bytes 843.63kB 0.05%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/mZ9ZBj925KtiJmngsmB5y/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/mZ9ZBj925KtiJmngsmB5y/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/hLal_VrFIVI6PwCKpIRuc/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/hLal_VrFIVI6PwCKpIRuc/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

| ------------------------------------------------------------------------------- | ----------- | ---------- | --------- | ----------- | --------- |
| Can see and edit billing information and subscription details || | | ||
| Can edit billing information and subscription details || | | ||
| Can see subscription details ||||||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: docs/organization/membership/index.mdx states all roles can see subscription details, contradicting other docs limiting access to Billing/Owner roles.
Severity: HIGH | Confidence: 0.95

🔍 Detailed Analysis

The pull request modifies docs/organization/membership/index.mdx to state that all organization roles (Billing, Member, Admin, Manager, Owner) can see subscription details. This contradicts existing documentation in docs/pricing/index.mdx, docs/pricing/legacy-pricing.mdx, docs/pricing/quotas/manage-attachments-quota.mdx, and docs/product/alerts/notifications/index.mdx, which consistently state that only Billing or Owner-level users have this permission. This inconsistency will confuse users who expect to access subscription details based on the membership table but are denied access in practice.

💡 Suggested Fix

Either revert the change in docs/organization/membership/index.mdx to reflect Billing/Owner-only access, or update all other relevant documentation files to align with the new statement that all roles can see subscription details.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/organization/membership/index.mdx#L37

Potential issue: The pull request modifies `docs/organization/membership/index.mdx` to
state that all organization roles (Billing, Member, Admin, Manager, Owner) can see
subscription details. This contradicts existing documentation in
`docs/pricing/index.mdx`, `docs/pricing/legacy-pricing.mdx`,
`docs/pricing/quotas/manage-attachments-quota.mdx`, and
`docs/product/alerts/notifications/index.mdx`, which consistently state that only
Billing or Owner-level users have this permission. This inconsistency will confuse users
who expect to access subscription details based on the membership table but are denied
access in practice.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the other pages, this shouldn't contradict any of them since those pages refer to editing actions, which remains unchanged in terms of perms

@isabellaenriquez isabellaenriquez merged commit eca3d69 into master Nov 3, 2025
13 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/bil-1720 branch November 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants