-
-
Notifications
You must be signed in to change notification settings - Fork 226
Update all samples to use the latest TFMs #4782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamescrosswell
wants to merge
25
commits into
main
Choose a base branch
from
update-sample-tfms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
70147ec
Sentry.Samples.Android
jamescrosswell de0dd5f
Sentry.Samples.GenericHost
jamescrosswell 3e928ae
Sentry.Samples.Ios
jamescrosswell d5f67da
Sentry.Samples.MacCatalyst
jamescrosswell 9c66c76
Sentry.Samples.MacOS
jamescrosswell 807bdf1
Sentry.Samples.Maui
jamescrosswell 3271051
Sentry.Samples.ME.Logging
jamescrosswell 3f650f1
Sentry.Samples.OpenTelemetry.AzureFunctions
jamescrosswell a9062c0
update WASM sample
Flash0ver 73914a6
update Mac Catalyst sample
Flash0ver 1e8c46e
Install workloads for test app
jamescrosswell db7e45f
Merge remote-tracking branch 'origin/update-sample-tfms' into update-…
jamescrosswell 62cd06a
.
jamescrosswell d591f4d
Merge branch 'main' into update-sample-tfms
jamescrosswell 9148ca9
Merge branch 'main' into update-sample-tfms
Flash0ver a6a1f06
disable Blazor WebAssembly ahead-of-time compilation
Flash0ver ea3ffe8
... and comment why
Flash0ver 53cb7d9
... and update WASM DSN
Flash0ver 395a8d2
Updated for consistency with mobile samples
jamescrosswell c065213
fix pragma
jamescrosswell 1d62bc8
Merge remote-tracking branch 'origin/main' into update-sample-tfms
jamescrosswell 6722643
Testing something insane...
jamescrosswell 0533bae
Format code
getsentry-bot 8004d7e
Revert "Testing something insane..."
jamescrosswell 3931889
Update samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Program.cs
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,6 @@ | ||
| <Router AppAssembly="@typeof(Program).Assembly"> | ||
| <Router AppAssembly="@typeof(App).Assembly" NotFoundPage="typeof(Pages.NotFound)"> | ||
| <Found Context="routeData"> | ||
| <RouteView RouteData="@routeData" DefaultLayout="@typeof(MainLayout)" /> | ||
| <FocusOnNavigate RouteData="@routeData" Selector="h1" /> | ||
| </Found> | ||
| <NotFound> | ||
| <LayoutView Layout="@typeof(MainLayout)"> | ||
| <p>Sorry, there's nothing at this address.</p> | ||
| </LayoutView> | ||
| </NotFound> | ||
| </Router> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Pages/NotFound.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @page "/not-found" | ||
| @layout MainLayout | ||
|
|
||
| <h3>Not Found</h3> | ||
| <p>Sorry, the content you are looking for does not exist.</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,9 @@ | |
| <NavMenu /> | ||
| </div> | ||
|
|
||
| <div> | ||
| @Body | ||
| </div> | ||
| <main> | ||
| <article class="content"> | ||
| @Body | ||
| </article> | ||
| </main> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
36 changes: 23 additions & 13 deletions
36
samples/Sentry.Samples.AspNetCore.Blazor.Wasm/wwwroot/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,33 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | ||
| <title>BlazorApp1</title> | ||
| <link href="app.css" rel="stylesheet"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Sentry.Samples.AspNetCore.Blazor.Wasm</title> | ||
| <base href="/" /> | ||
| <link rel="preload" id="webassembly" /> | ||
| <link rel="stylesheet" href="app.css" /> | ||
| <link rel="icon" type="image/png" href="favicon.png" /> | ||
| <link href="Sentry.Samples.AspNetCore.Blazor.Wasm.styles.css" rel="stylesheet" /> | ||
| <script type="importmap"></script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="app">Loading...</div> | ||
| <div id="app"> | ||
| <svg class="loading-progress"> | ||
| <circle r="40%" cx="50%" cy="50%" /> | ||
| <circle r="40%" cx="50%" cy="50%" /> | ||
| </svg> | ||
| <div class="loading-progress-text"></div> | ||
| </div> | ||
|
|
||
| <div id="blazor-error-ui"> | ||
| An unhandled error has occurred. | ||
| <a href="" class="reload">Reload</a> | ||
| <a class="dismiss">🗙</a> | ||
| </div> | ||
|
|
||
| <script src="_framework/blazor.webassembly.js"></script> | ||
| <div id="blazor-error-ui"> | ||
| An unhandled error has occurred. | ||
| <a href="." class="reload">Reload</a> | ||
| <span class="dismiss">🗙</span> | ||
| </div> | ||
| <script src="_framework/blazor.webassembly#[.{fingerprint}].js"></script> | ||
| </body> | ||
|
|
||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing @ prefix in Razor attribute expression
The
NotFoundPageattribute value is missing the@prefix for the C# expression. The valuetypeof(Pages.NotFound)is being treated as a string literal instead of a type expression. Compare withAppAssembly="@typeof(App).Assembly"andDefaultLayout="@typeof(MainLayout)"on the same component which correctly use the@prefix. This will cause the Router to not properly recognize the NotFound page type.