Skip to content

chore: Update all samples to use the latest TFMs#4782

Merged
jamescrosswell merged 32 commits intomainfrom
update-sample-tfms
Feb 4, 2026
Merged

chore: Update all samples to use the latest TFMs#4782
jamescrosswell merged 32 commits intomainfrom
update-sample-tfms

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Dec 2, 2025

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.85%. Comparing base (09a72cb) to head (6412515).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
- Coverage   73.87%   73.85%   -0.02%     
==========================================
  Files         483      483              
  Lines       17578    17578              
  Branches     3464     3464              
==========================================
- Hits        12985    12983       -2     
- Misses       3740     3741       +1     
- Partials      853      854       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Dec 3, 2025

The error we're seeing now in CI is:

/usr/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/10.0.0/Sdk/WasmApp.Common.targets(853,5): error : /usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.linux-musl-arm64/10.0.0/tools/bin/clang: line 25: /usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.linux-musl-arm64/10.0.0/tools/bin/clang-19: not found [took 0.65s] [/__w/sentry-dotnet/sentry-dotnet/samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Sentry.Samples.AspNetCore.Blazor.Wasm.csproj]

This may be related to:

@Flash0ver potentially we revert to net9 for the WASM sample until this is a bit more stable in .net 10?

@jamescrosswell jamescrosswell marked this pull request as ready for review December 4, 2025 21:51
@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Dec 8, 2025

Inexplicably, this commit seems to have broken the unit tests on linux-musl-x64. They don't fail... they just never complete and we can't get at the logs to work out why. 😞

Possibly the commit is entirely unrelated but, if so, I can't see any other differences between the environments between the successful and unsuccessful runs.

Commit 6722643 confirms it's nothing to do with the change, but we do finally get some clues from the logs:

Error: System.IO.IOException : No space left on device : '/tmp/1d608ce7-dee1-427a-8947-daac2bd3a2b1'

getsentry-bot and others added 2 commits December 8, 2025 00:32
This reverts commit 6722643.

# Conflicts:
#	samples/Sentry.Samples.Ios/AppDelegate.cs
@@ -1,10 +1,6 @@
<Router AppAssembly="@typeof(Program).Assembly">
<Router AppAssembly="@typeof(App).Assembly" NotFoundPage="typeof(Pages.NotFound)">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing @ prefix in Razor attribute expression

The NotFoundPage attribute value is missing the @ prefix for the C# expression. The value typeof(Pages.NotFound) is being treated as a string literal instead of a type expression. Compare with AppAssembly="@typeof(App).Assembly" and DefaultLayout="@typeof(MainLayout)" on the same component which correctly use the @ prefix. This will cause the Router to not properly recognize the NotFound page type.

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@jamescrosswell jamescrosswell merged commit cbd1f38 into main Feb 4, 2026
53 of 54 checks passed
@jamescrosswell jamescrosswell deleted the update-sample-tfms branch February 4, 2026 22:07
@jamescrosswell jamescrosswell changed the title Update all samples to use the latest TFMs chore: Update all samples to use the latest TFMs Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all samples to use the latest TFM

3 participants