Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Dec 2, 2025

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.88%. Comparing base (d6d4cde) to head (1d62bc8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
- Coverage   73.90%   73.88%   -0.02%     
==========================================
  Files         485      485              
  Lines       17682    17682              
  Branches     3494     3494              
==========================================
- Hits        13067    13064       -3     
- Misses       3758     3763       +5     
+ Partials      857      855       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Dec 3, 2025

The error we're seeing now in CI is:

/usr/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/10.0.0/Sdk/WasmApp.Common.targets(853,5): error : /usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.linux-musl-arm64/10.0.0/tools/bin/clang: line 25: /usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.linux-musl-arm64/10.0.0/tools/bin/clang-19: not found [took 0.65s] [/__w/sentry-dotnet/sentry-dotnet/samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Sentry.Samples.AspNetCore.Blazor.Wasm.csproj]

This may be related to:

@Flash0ver potentially we revert to net9 for the WASM sample until this is a bit more stable in .net 10?

Comment on lines 10 to 14
#if SENTRY_DSN_DEFINED_IN_ENV
// A DSN is required. You can set here in code. Web browsers cannot read environment variables.
// See https://docs.sentry.io/product/sentry-basics/dsn-explainer/
options.Dsn = SamplesShared.Dsn;
options.Dsn = EnvironmentVariables.Dsn;
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Fixes WASM DSN issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flash0ver after reading your fix, I remembered why we have that EnvironmentVariables class, so I tweaked/updated to be consistent with how we've done this in the mobile samples.

#if !SENTRY_DSN_DEFINED_IN_ENV
// You must specify a DSN. On mobile platforms, this should be done in code here.
// See https://docs.sentry.io/product/sentry-basics/dsn-explainer/
options.Dsn = SamplesShared.Dsn;
#else
// To make things easier for the SDK maintainers we have a custom build target that writes the
// SENTRY_DSN environment variable into an EnvironmentVariables class that is available for mobile
// targets. This allows us to share one DSN defined in the ENV across desktop and mobile samples.
// Generally, you won't want to do this in your own mobile projects though - you should set the DSN
// in code as above
options.Dsn = EnvironmentVariables.Dsn;
#endif

@jamescrosswell jamescrosswell marked this pull request as ready for review December 4, 2025 21:51
@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Dec 8, 2025

Inexplicably, this commit seems to have broken the unit tests on linux-musl-x64. They don't fail... they just never complete and we can't get at the logs to work out why. 😞

Possibly the commit is entirely unrelated but, if so, I can't see any other differences between the environments between the successful and unsuccessful runs.

Commit 6722643 confirms it's nothing to do with the change, but we do finally get some clues from the logs:

Error: System.IO.IOException : No space left on device : '/tmp/1d608ce7-dee1-427a-8947-daac2bd3a2b1'

// targets. This allows us to share one DSN defined in the ENV across desktop and mobile samples.
// Generally, you won't want to do this in your own WASM applications - you should set the DSN
// in code as above
options.Dsn = EnvironmentVariables.Dsn;

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all samples to use the latest TFM

4 participants