chore: Update all samples to use the latest TFMs#4782
Conversation
Note that I can't test this (my Apple Developer account has expired)... hoping Stefan can help :-)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
==========================================
- Coverage 73.87% 73.85% -0.02%
==========================================
Files 483 483
Lines 17578 17578
Branches 3464 3464
==========================================
- Hits 12985 12983 -2
- Misses 3740 3741 +1
- Partials 853 854 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The error we're seeing now in CI is: This may be related to: @Flash0ver potentially we revert to net9 for the WASM sample until this is a bit more stable in .net 10? |
samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Sentry.Samples.AspNetCore.Blazor.Wasm.csproj
Show resolved
Hide resolved
|
Inexplicably, this commit seems to have broken the unit tests on Possibly the commit is entirely unrelated but, if so, I can't see any other differences between the environments between the successful and unsuccessful runs. Commit 6722643 confirms it's nothing to do with the change, but we do finally get some clues from the logs:
|
This reverts commit 6722643. # Conflicts: # samples/Sentry.Samples.Ios/AppDelegate.cs
| @@ -1,10 +1,6 @@ | |||
| <Router AppAssembly="@typeof(Program).Assembly"> | |||
| <Router AppAssembly="@typeof(App).Assembly" NotFoundPage="typeof(Pages.NotFound)"> | |||
There was a problem hiding this comment.
Bug: Missing @ prefix in Razor attribute expression
The NotFoundPage attribute value is missing the @ prefix for the C# expression. The value typeof(Pages.NotFound) is being treated as a string literal instead of a type expression. Compare with AppAssembly="@typeof(App).Assembly" and DefaultLayout="@typeof(MainLayout)" on the same component which correctly use the @ prefix. This will cause the Router to not properly recognize the NotFound page type.
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Resolves #4584
#skip-changelog