feat: Network calls for Session Replay on Android#4860
Open
jamescrosswell wants to merge 20 commits intomainfrom
Open
feat: Network calls for Session Replay on Android#4860jamescrosswell wants to merge 20 commits intomainfrom
jamescrosswell wants to merge 20 commits intomainfrom
Conversation
jamescrosswell
commented
Jan 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
- Coverage 73.87% 73.85% -0.02%
==========================================
Files 483 483
Lines 17578 17581 +3
Branches 3464 3465 +1
==========================================
Hits 12985 12985
- Misses 3740 3742 +2
- Partials 853 854 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
changed the title
jamescrosswell
commented
Jan 27, 2026
Collaborator
Author
There was a problem hiding this comment.
I've moved most of this out to a separate PR as well, since it's just a means to an end to diagnose the problem (not actually part of the change this PR is meant to effect):
… .NET and Java replay breadcrumbs
This was referenced Feb 3, 2026
jamescrosswell
changed the title
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
Test
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Flash0ver
reviewed
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4192:
This PR ensures performanceSpans are sent with replay events so that outbound network requests in Maui for Android are displayed correctly in the
Replay -> Networktab.Implementation notes
The performanceSpan itself doesn't include a replyId, so it has to be sent along with the replay event - i.e. it gets sent by the mobile/Android SDK. The way android does this is to inspect the stream of breadcrumbs and convert these into RRWeb custom events. Typicallly this is done via the DefaultBreadcrumbConverter but it's also possible to swap that out with a custom converter (which is what our ReactNative SDK does).
This PR is an attempt to utilise the
DefaultReplayBreadcrumbConverterby ensuring that our breadcrumbs contain all the data properties it's expecting.Additional comments
If we eventually try to implement this for iOS, iOS looks for slightly different field names