-
-
Notifications
You must be signed in to change notification settings - Fork 230
fix: libmonosgen and libxamarin frames currently showing as inapp #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
a691d2b
0312d6e
a46588b
e0cb929
e817859
4f23fd8
45d5543
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| namespace Sentry.Internal; | ||
|
|
||
| internal static partial class InAppExcludeRegexes | ||
| { | ||
| // (^|[/\\]) — anchors to start of string or after a forward/backward slash | ||
| // ([^/\\]*libmonosgen[^/\\]*) — last segment contains libmonosgen (no slashes before/after) | ||
| // $ — end of string | ||
| private const string LibMonoSgenPattern = @"(^|[/\\])([^/\\]*libmonosgen[^/\\]*)$"; | ||
|
|
||
| // (^|[/\\]) — anchors to start of string or after a forward/backward slash | ||
| // ([^/\\]*libxamarin[^/\\]*) — last segment contains libxamarin (no slashes before/after) | ||
| // $ — end of string | ||
| private const string LibXamarinPattern = @"(^|[/\\])([^/\\]*libxamarin[^/\\]*)$"; | ||
|
|
||
| #if NET9_0_OR_GREATER | ||
| [GeneratedRegex(LibMonoSgenPattern)] | ||
| internal static partial Regex LibMonoSgen { get; } | ||
|
|
||
| [GeneratedRegex(LibXamarinPattern)] | ||
| internal static partial Regex LibXamarin { get; } | ||
|
Comment on lines
+15
to
+20
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: use re
|
||
| #elif NET8_0 | ||
| [GeneratedRegex(LibMonoSgenPattern)] | ||
| private static partial Regex LibMonoSgenRegex(); | ||
| internal static readonly Regex LibMonoSgen = LibMonoSgenRegex(); | ||
|
|
||
| [GeneratedRegex(LibXamarinPattern)] | ||
| private static partial Regex LibXamarinRegex(); | ||
| internal static readonly Regex LibXamarin = LibXamarinRegex(); | ||
| #else | ||
jamescrosswell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| internal static readonly Regex LibMonoSgen = new(LibMonoSgenPattern, RegexOptions.Compiled); | ||
| internal static readonly Regex LibXamarin = new(LibXamarinPattern, RegexOptions.Compiled); | ||
| #endif | ||
| } | ||
jamescrosswell marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.