chore: Removed redundant enrichting during feedback processing#5041
Merged
chore: Removed redundant enrichting during feedback processing#5041
feedback processing#5041Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
feedback processing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5041 +/- ##
==========================================
- Coverage 74.03% 74.02% -0.01%
==========================================
Files 499 499
Lines 18044 18048 +4
Branches 3510 3512 +2
==========================================
+ Hits 13358 13360 +2
- Misses 3830 3831 +1
- Partials 856 857 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Flash0ver
approved these changes
Mar 19, 2026
Member
Flash0ver
left a comment
There was a problem hiding this comment.
Great catch! Thank you so much 🥔!
I couldn't resist adding an assertion 😉.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #4942
The enricher was explicitly invoked, but now with letting the feedback go through the event-processors the enriching is duplicated. The
MainSentryEventProcessoris taking care of this.sentry-dotnet/src/Sentry/Internal/MainSentryEventProcessor.cs
Line 157 in 58c1a81
#skip-changelog