Skip to content

chore: Removed redundant enrichting during feedback processing#5041

Merged
Flash0ver merged 2 commits intomainfrom
chore/remove-redundant-enrichtment
Mar 19, 2026
Merged

chore: Removed redundant enrichting during feedback processing#5041
Flash0ver merged 2 commits intomainfrom
chore/remove-redundant-enrichtment

Conversation

@bitsandfoxes
Copy link
Copy Markdown
Contributor

Followup on #4942

The enricher was explicitly invoked, but now with letting the feedback go through the event-processors the enriching is duplicated. The MainSentryEventProcessor is taking care of this.

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@bitsandfoxes bitsandfoxes changed the title chore: Removed redundant enrichting during event processing chore: Removed redundant enrichting during feedback processing Mar 19, 2026
@bitsandfoxes bitsandfoxes changed the title chore: Removed redundant enrichting during feedback processing chore: Removed redundant enrichting during feedback processing Mar 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.02%. Comparing base (a4a8ded) to head (b6cd7da).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5041      +/-   ##
==========================================
- Coverage   74.03%   74.02%   -0.01%     
==========================================
  Files         499      499              
  Lines       18044    18048       +4     
  Branches     3510     3512       +2     
==========================================
+ Hits        13358    13360       +2     
- Misses       3830     3831       +1     
- Partials      856      857       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@Flash0ver Flash0ver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you so much 🥔!
I couldn't resist adding an assertion 😉.

@Flash0ver Flash0ver merged commit eb30642 into main Mar 19, 2026
45 checks passed
@Flash0ver Flash0ver deleted the chore/remove-redundant-enrichtment branch March 19, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants