Skip to content

chore: Removed redundant enrichting during feedback processing #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flash0ver merged 2 commits into from
Mar 19, 2026
Merged

chore: Removed redundant enrichting during feedback processing #5041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4789ad8
removed redundant enrichting
bitsandfoxes Mar 19, 2026
b6cd7da
test: add assertion
Flash0ver Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Sentry/SentryClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ public SentryId CaptureFeedback(SentryFeedback feedback, out CaptureFeedbackResu
// Evaluate and copy before invoking the callback
scope.Evaluate();
scope.Apply(evt);
_enricher.Apply(evt);

if (scope.Level != null && scope.Level != SentryLevel.Info)
{
Expand Down
1 change: 1 addition & 0 deletions test/Sentry.Tests/SentryClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,7 @@ public void CaptureFeedback_WithEventProcessor_EventProcessorApplied()
var item = envelope.Items.First(x => x.TryGetType() == EnvelopeItem.TypeValueFeedback);
var @event = (SentryEvent)((JsonSerializable)item.Payload).Source;
@event.Environment.Should().Be("testing 123");
@event.Sdk.InternalPackages.Should().ContainSingle().Which.Name.Should().Be("nuget:sentry.dotnet");
}

[Fact]
Expand Down
Loading