WIP otel auto setup #711
Closed
WIP otel auto setup #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/otel-exporter
branch
from
8a7efaa to
ff149b4
Compare
yordis
reviewed
Jul 20, 2024
Comment on lines
+7
to
+12
| if Config.dsn() do | ||
| Application.put_env(:opentelemetry, :traces_exporter, :otlp) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_protocol, :http_protobuf) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_traces_endpoint, Config.spans_endpoint()) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_headers, Config.auth_headers()) | ||
| end |
There was a problem hiding this comment.
I honestly believe this is a suboptimal idea.
The OTEL spec expects environment configuration to work correctly, among other things. DevOps wouldn't like this, and troubleshooting will require knowing this code exists instead of, for the most part, checking the config directory.
I have already encountered problems with adding or expecting global environment configuration, which has caused significant headaches.
Proper documentation significantly goes a long way when these configurations barely change.
|
@sl0thentr0py I suppose this should be closed in favor of #784? |
|
yep, no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.