-
-
Notifications
You must be signed in to change notification settings - Fork 207
WIP otel auto setup #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
WIP otel auto setup #711
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| defmodule Sentry.Integrations.Opentelemetry do | ||
| @moduledoc false | ||
|
|
||
| alias Sentry.Config | ||
|
|
||
| def setup do | ||
| if Config.dsn() do | ||
| Application.put_env(:opentelemetry, :traces_exporter, :otlp) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_protocol, :http_protobuf) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_traces_endpoint, Config.spans_endpoint()) | ||
| Application.put_env(:opentelemetry_exporter, :otlp_headers, Config.auth_headers()) | ||
| end | ||
|
|
||
| :ok | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,15 +6,15 @@ defmodule Sentry.ConfigTest do | |
| describe "validate!/0" do | ||
| test ":dsn from option" do | ||
| assert Config.validate!(dsn: "https://public:[email protected]/1")[:dsn] == | ||
| {"https://app.getsentry.com/api/1/envelope/", "public", "secret"} | ||
| {"https://app.getsentry.com/api/1/", "public", "secret"} | ||
|
|
||
| assert Config.validate!(dsn: nil)[:dsn] == nil | ||
| end | ||
|
|
||
| test ":dsn from system environment" do | ||
| with_system_env("SENTRY_DSN", "https://public:[email protected]/1", fn -> | ||
| assert Config.validate!([])[:dsn] == | ||
| {"https://app.getsentry.com/api/1/envelope/", "public", "secret"} | ||
| {"https://app.getsentry.com/api/1/", "public", "secret"} | ||
| end) | ||
| end | ||
|
|
||
|
|
@@ -213,7 +213,7 @@ defmodule Sentry.ConfigTest do | |
| assert :ok = Config.put_config(:dsn, new_dsn) | ||
|
|
||
| assert Config.dsn() == | ||
| {"https://app.getsentry.com/api/2/envelope/", "public", "secret"} | ||
| {"https://app.getsentry.com/api/2/", "public", "secret"} | ||
| end | ||
|
|
||
| test "validates the given key" do | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly believe this is a suboptimal idea.
The OTEL spec expects environment configuration to work correctly, among other things. DevOps wouldn't like this, and troubleshooting will require knowing this code exists instead of, for the most part, checking the
configdirectory.I have already encountered problems with adding or expecting global environment configuration, which has caused significant headaches.
Proper documentation significantly goes a long way when these configurations barely change.