-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: update biome to v1.8.0 #12352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's talk about this some more, I think we are unlikely to merge this because we are still having too many problems with biome, sadly 😬 mainly they are problems with editor integrations (in VSCode, but even more so in IntelliJ), not biome itself, but it does not change the fact that it is sadly reducing our productivity, not increasing it. We'll probably look to revert back to use prettier overall, honestly - don't get me wrong, biome is cool and really fast, but the ability to ship stuff fast has the highest prio for us, and as of today it is not helping us in this regard (yet). |
New versions will likely fix your problems not add new pain points. |
I think the primary blocker is not from |
Editor integrations run the local biome binary. Updating local version will improve editor integrations since those integrations doesn't ship/bundle with their own Biome executable |
❌ 13 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
import astroLogo from '../assets/astro.svg'; | ||
import background from '../assets/background.svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm looks like biome doesn't play well with astro? These imports are not unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused rule can be disabled in override for urls ending with .astro
Closing, we reverted to prettier for now |
I think the time has come to update Biome. My previous attempt to update was almost 3 months, which didn't get a single pull-request review: #10994
I recommend watching this: https://www.youtube.com/watch?v=Yv9tQRPf3nE
cc @getsentry/team-web-sdk-frontend