Skip to content

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jun 4, 2024

I think the time has come to update Biome. My previous attempt to update was almost 3 months, which didn't get a single pull-request review: #10994

I recommend watching this: https://www.youtube.com/watch?v=Yv9tQRPf3nE

cc @getsentry/team-web-sdk-frontend

@anonrig anonrig requested review from a team as code owners June 4, 2024 15:08
@mydea
Copy link
Member

mydea commented Jun 7, 2024

Let's talk about this some more, I think we are unlikely to merge this because we are still having too many problems with biome, sadly 😬 mainly they are problems with editor integrations (in VSCode, but even more so in IntelliJ), not biome itself, but it does not change the fact that it is sadly reducing our productivity, not increasing it. We'll probably look to revert back to use prettier overall, honestly - don't get me wrong, biome is cool and really fast, but the ability to ship stuff fast has the highest prio for us, and as of today it is not helping us in this regard (yet).

@anonrig
Copy link
Contributor Author

anonrig commented Jun 7, 2024

New versions will likely fix your problems not add new pain points.

@AbhiPrasad
Copy link
Member

I think the primary blocker is not from biome itself in this case, it's with the editor integrations. Considering that is disrupting people's workflows, I'm also in favour of holding off on biome and waiting for these integrations to improve.

@anonrig anonrig closed this Jun 7, 2024
@anonrig
Copy link
Contributor Author

anonrig commented Jun 7, 2024

I think the primary blocker is not from biome itself in this case, it's with the editor integrations. Considering that is disrupting people's workflows, I'm also in favour of holding off on biome and waiting for these integrations to improve.

Editor integrations run the local biome binary. Updating local version will improve editor integrations since those integrations doesn't ship/bundle with their own Biome executable

Copy link

codecov bot commented Dec 13, 2024

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
604 13 591 293
View the top 3 failed tests by shortest run time
performance.test.ts sends a lifecycle span for each tracked components
Stack Traces | 3.12s run time
performance.test.ts:126:1 sends a lifecycle span for each tracked components
performance.test.ts performance eventscapture a distributed pageload trace
Stack Traces | 10.1s run time
performance.test.ts:6:3 capture a distributed pageload trace
performance.test.ts sends a pageload transaction with component tracking init spans
Stack Traces | 15.2s run time
performance.test.ts:4:1 sends a pageload transaction with component tracking init spans

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Comment on lines -2 to -3
import astroLogo from '../assets/astro.svg';
import background from '../assets/background.svg';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm looks like biome doesn't play well with astro? These imports are not unused

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused rule can be disabled in override for urls ending with .astro

@Lms24
Copy link
Member

Lms24 commented Mar 4, 2025

Closing, we reverted to prettier for now

@Lms24 Lms24 closed this Mar 4, 2025
@AbhiPrasad AbhiPrasad deleted the anonrig/update-biome-1-8-0 branch March 27, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants