Skip to content

chore: update biome to v1.8.0 #12352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

chore: update biome to v1.8.0 #12352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a1b3a0
chore: update biome to v1.8.0
anonrig Jun 4, 2024
f2c1e3d
Merge branch 'develop' into anonrig/update-biome-1-8-0
andreiborza Dec 13, 2024
6562cc3
Merge branch 'develop' into anonrig/update-biome-1-8-0
andreiborza Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@
"recommended": false,
"correctness": {
"all": false,
"noUnusedVariables": "error",
"noPrecisionLoss": "error"
"noPrecisionLoss": "error",
"noUnusedImports": "error"
},
"complexity": {
"all": false,
"useRegexLiterals": "error"
},
"complexity": {
"useRegexLiterals": "error"
Expand All @@ -25,13 +29,12 @@
"all": false,
"noControlCharactersInRegex": "error"
},
"nursery": {
"noUnusedImports": "error"
},
"performance": {
"all": true,
"noAccumulatingSpread": "error",
"noDelete": "off"
"noDelete": "off",
"noBarrelFile": "off",
"noReExportAll": "off"
}
},
"ignore": [
Expand Down Expand Up @@ -85,7 +88,7 @@
"enabled": true,
"quoteStyle": "single",
"arrowParentheses": "asNeeded",
"trailingComma": "all",
"trailingCommas": "all",
"lineEnding": "lf"
},
"parser": {
Expand Down
2 changes: 1 addition & 1 deletion .../browser-integration-tests/suites/tracing/metrics/web-vitals-cls-standalone-spans/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Page } from '@playwright/test';
import { expect } from '@playwright/test';
import type { Event as SentryEvent, EventEnvelope, SpanEnvelope } from '@sentry/core';
import type { EventEnvelope, Event as SentryEvent, SpanEnvelope } from '@sentry/core';

import { sentryTest } from '../../../../utils/fixtures';
import {
Expand Down
5 changes: 1 addition & 4 deletions dev-packages/e2e-tests/test-applications/angular-17/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@
"target": "ES2022",
"module": "ES2022",
"useDefineForClassFields": false,
"lib": [
"ES2022",
"dom"
]
"lib": ["ES2022", "dom"]
},
"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
Expand Down
5 changes: 1 addition & 4 deletions dev-packages/e2e-tests/test-applications/angular-18/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@
"target": "ES2022",
"module": "ES2022",
"useDefineForClassFields": false,
"lib": [
"ES2022",
"dom"
]
"lib": ["ES2022", "dom"]
},
"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/astro-4/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
interface Props {
title: string;
title: string;
}

const { title } = Astro.props;
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/astro-4/src/pages/client-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";
---

<Layout title="Client Error">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-4/src/pages/endpoint-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

export const prerender = false;
---

Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/astro-4/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
import Layout from '../layouts/Layout.astro';
---

<Layout title="Welcome to Astro.">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-4/src/pages/ssr-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

const a = {} as any;
console.log(a.foo.x);
export const prerender = false;
Expand Down
4 changes: 1 addition & 3 deletions dev-packages/e2e-tests/test-applications/astro-4/src/pages/test-ssr/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
import Layout from "../../layouts/Layout.astro"

export const prerender = false
export const prerender = false;
---

<Layout title="Dynamic SSR page">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-4/src/pages/test-static/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

export const prerender = true;
---

Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/astro-4/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "astro/tsconfigs/strict"
}
}
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-5/src/components/Welcome.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import astroLogo from '../assets/astro.svg';
import background from '../assets/background.svg';
Comment on lines -2 to -3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm looks like biome doesn't play well with astro? These imports are not unused

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused rule can be disabled in override for urls ending with .astro

---

<div id="container">
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/astro-5/src/pages/client-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";
---

<Layout title="Client Error">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/endpoint-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

export const prerender = false;
---

Expand Down
3 changes: 0 additions & 3 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
---
import Welcome from '../components/Welcome.astro';
import Layout from '../layouts/Layout.astro';

// Welcome to Astro! Wondering what to do next? Check out the Astro documentation at https://docs.astro.build
// Don't want to use any of this? Delete everything in this file, the `assets`, `components`, and `layouts` directories, and start fresh.
---
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/server-island/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
---
import Avatar from '../../components/Avatar.astro';
import Layout from '../../layouts/Layout.astro';

export const prerender = true;
---
<Layout title="Server Island Page">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/ssr-error/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

const a = {} as any;
console.log(a.foo.x);
export const prerender = false;
Expand Down
4 changes: 1 addition & 3 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/test-ssr/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
import Layout from "../../layouts/Layout.astro"

export const prerender = false
export const prerender = false;
---

<Layout title="Dynamic SSR page">
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/astro-5/src/pages/test-static/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from "../../layouts/Layout.astro";

export const prerender = true;
---

Expand Down
3 changes: 1 addition & 2 deletions dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"test:build": "pnpm install && pnpm copy:layer",
"test:assert": "pnpm test"
},
"dependencies": {
},
"dependencies": {},
"devDependencies": {
"@sentry-internal/test-utils": "link:../../../test-utils",
"@playwright/test": "^1.44.1"
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/cloudflare-astro/src/components/Card.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
interface Props {
title: string;
body: string;
href: string;
title: string;
body: string;
href: string;
}

const { href, title, body } = Astro.props;
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/cloudflare-astro/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
interface Props {
title: string;
title: string;
}

const { title } = Astro.props;
Expand Down
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/cloudflare-astro/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
import Layout from '../layouts/Layout.astro';
import Card from '../components/Card.astro';
---

<Layout title="Welcome to Astro.">
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/cloudflare-workers/test/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, expect, it } from 'vitest';
import worker from '../src/index';
// test/index.spec.ts
import { SELF, createExecutionContext, env, waitOnExecutionContext } from 'cloudflare:test';
import { describe, expect, it } from 'vitest';
import worker from '../src/index';

// For now, you'll need to do something like this to get a correctly-typed
// `Request` to pass to `worker.fetch()`.
Expand Down
12 changes: 6 additions & 6 deletions dev-packages/e2e-tests/test-applications/cloudflare-workers/test/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"types": ["@cloudflare/workers-types/experimental", "@cloudflare/vitest-pool-workers"]
},
"include": ["./**/*.ts", "../src/env.d.ts"],
"exclude": []
"extends": "../tsconfig.json",
"compilerOptions": {
"types": ["@cloudflare/workers-types/experimental", "@cloudflare/vitest-pool-workers"]
},
"include": ["./**/*.ts", "../src/env.d.ts"],
"exclude": []
}
Loading
Loading