test(e2e/firebase): Fix firebase e2e test failing due to outdated rules file #17448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test our firebase instrumentation, we spin up a firebase emulator with firestore rules.
Looks like by default, the generated rules file was set to only allow general data access for 30 days. This caused CI to suddenly fail from Aug 17 onwards (and went unnoticed until today due to Hackweek).
Since this is just us running the emulator in a CI job, I think it's okay to allow access unconditionally. Not sure though, so happy to think of something else if reviewers have concerns.