feat(browser): Add replay.feedback CDN bundle #17496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| browserTracingIntegrationShim as browserTracingIntegration, | ||
| feedbackAsyncIntegration as feedbackAsyncIntegration, | ||
| feedbackAsyncIntegration as feedbackIntegration, | ||
| }; |
There was a problem hiding this comment.
Bug: Replay Feedback Bundle Inconsistent Tracing Shim
The replay.feedback bundle currently imports and exports browserTracingIntegrationShim. This bundle is designed for replay and feedback functionality only, so including a tracing shim here is inconsistent with its intended scope and may cause confusion.
chargome
approved these changes
Sep 1, 2025
Lms24
approved these changes
Sep 1, 2025
I think it's OK, we do not need every variation in size report, the full bundle is nice and then one of errors + feature only each IMHO to see the individual impact of a feature :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we originally decided to only have a error + feedback bundle and a error + tracing + replay + feedback bundle for simplicity. But I suppose it does not really make things easier that there is exactly one (error + replay + feedback) missing, so I'd just add this here now. Esp. if we want to add this in the loader this will be much easier to handle.