fix(astro): Ensure span name from beforeStartSpan isn't overwritten
#17500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
3 tasks
Lms24
requested review from
a team and
andreiborza
and removed request for
a team
mydea
approved these changes
Sep 1, 2025
s1gr1d
approved these changes
Sep 1, 2025
Lms24
added a commit
that referenced
this pull request
Sep 2, 2025
…in-place in `beforeStartSpan` (#17501) When using `beforeStartSpan` in `browserTracingIntgration`, we document that users should return a new options object rather than mutating the passed in object in-place. However, nothing keeps users from setting the name in-place like so:' ```js browserTracingIntegration({ beforeStartSpan: opts => { opts.name = 'changed'; return opts; }, }), ``` In such a case, we previously didn't catch the mutation and wouldn't adjust the span source attribute to `'custom'` accordingly. This PR ensures we take care of this case, too. (found while writing a test for #17500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in our Astro SDK's
browserTracingIntegration. Previously, if users followed our docs how to set a custom span name for the pageload span viabeforeStartSpan, the name would get overwritten by our route parameterization logic. This was because the route parametrization logic ran after the span was already created and it would simply update the span name.In this case though, we can already start the span with the parameterized name instead of updating after it was started. This has a couple of advantages:
source: 'url'name before updating it toroute.beforeStartSpanto set the span name to be applied correctly (i.e. fixes this bug).Admittedly, my fix isn't the simplest possible fix (which would have been to just check for the source before updating the span name to the parameterized name). However, I think that starting the span right away with the correct name is the overall better outcome.
closes #17487