fix(browser): Ensure source is set correctly when updating span name in-place in beforeStartSpan
#17501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
beforeStartSpan
inbrowserTracingIntgration
, we document that users should return a new options object rather than mutating the passed in object in-place. However, nothing keeps users from setting the name in-place like so:'In such a case, we previously didn't catch the mutation and wouldn't adjust the span source attribute to
'custom'
accordingly. This PR ensures we take care of this case, too. (found while writing a test for #17500)