Skip to content

Conversation

@k-fish
Copy link
Member

@k-fish k-fish commented Sep 20, 2023

This will add the FID element so that it's possible to tell which element is involved in the delay, which is extremely helpful for debugging.

@k-fish k-fish requested a review from AbhiPrasad September 20, 2023 16:19
@github-actions
Copy link
Contributor

⚠️ This PR is opened against master. You probably want to open it against develop.

@k-fish k-fish changed the base branch from master to develop September 20, 2023 16:20
k-fish and others added 2 commits October 6, 2023 10:18
This will add the FID element so that it's possible to tell which element is involved in the delay, which is extremely helpful for debugging.
@k-fish k-fish force-pushed the ref/tracing-add-fid-element branch from 0b6bd83 to 28f7823 Compare October 6, 2023 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.27 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.44 KB (+0.09% 🔺)
@sentry/browser - Webpack (gzipped) 22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.8 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.62 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.44 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.72 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.35 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.48 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.3 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.05 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.26 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.02 KB (+0.06% 🔺)

@mydea
Copy link
Member

mydea commented Apr 17, 2024

Is this still something we want to do, or can we close this PR? @k-fish

@andreiborza
Copy link
Member

@k-fish is this still something we want or can we close this PR?

@k-fish
Copy link
Member Author

k-fish commented Jan 8, 2025

@andreiborza we should add element for FID, though I'm not sure setTag will be the preferred approach going forward.

@Lms24
Copy link
Member

Lms24 commented Jul 7, 2025

Given web-vitals dropped support for FID and we'll likely remove sending FID in v10/11 (#16560, also synced with the performance team on this), I'd close this PR.

@k-fish let me know if we should still ship the element in the meantime

@Lms24 Lms24 closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants