Skip to content

ref(tracing): Add FID element to frontend transactions #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ref(tracing): Add FID element to frontend transactions #9075

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e8001b
ref(tracing): Add FID element to frontend transactions
k-fish Sep 20, 2023
28f7823
Fix type
k-fish Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/tracing-internal/src/browser/metrics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ let _performanceCursor: number = 0;
let _measurements: Measurements = {};
let _lcpEntry: LargestContentfulPaint | undefined;
let _clsEntry: LayoutShift | undefined;
let _fidEntry: PerformanceEventTiming | undefined;

/**
* Start tracking web vitals
Expand Down Expand Up @@ -160,6 +161,7 @@ function _trackFID(): void {
__DEBUG_BUILD__ && logger.log('[Measurements] Adding FID');
_measurements['fid'] = { value: metric.value, unit: 'millisecond' };
_measurements['mark.fid'] = { value: timeOrigin + startTime, unit: 'second' };
_fidEntry = entry as PerformanceEventTiming;
});
}

Expand Down Expand Up @@ -500,4 +502,10 @@ function _tagMetricInfo(transaction: Transaction): void {
transaction.setTag(`cls.source.${index + 1}`, htmlTreeAsString(source.node)),
);
}


// Capture FID properties
if (_fidEntry && _fidEntry.target) {
transaction.setTag('fid.element', htmlTreeAsString(_fidEntry.target));
}
}