test: Remove test_installed_modules
#4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `test_installed_modules` appears to not be all that useful. The test exists to verify the behavior of the [`_generate_installed_modules` function](https://github.com/getsentry/sentry-python/blob/9b66f3b51502ca600554c711bc3f599c18f8f18b/sentry_sdk/utils.py#L1689). However, all the test does is essentially check the output of `_generate_installed_modules` against a refactored version of the function call itself. In short, in its current form, the test appears to not make too much sense. As the test recently started failing, let's just delete it.
sl0thentr0py
approved these changes
Jul 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4593 +/- ##
==========================================
- Coverage 80.72% 80.68% -0.04%
==========================================
Files 156 156
Lines 16507 16507
Branches 2806 2806
==========================================
- Hits 13325 13319 -6
- Misses 2295 2298 +3
- Partials 887 890 +3 |
Member
|
gevent flaky test will be fixed in #4590 |
szokeasaurusrex
deleted the
szokeasaurusrex/remove-test_installed_modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_installed_modulesappears to not be all that useful.The test exists to verify the behavior of the
_generate_installed_modulesfunction. However, all the test does is essentially check the output of_generate_installed_modulesagainst a refactored version of the function call itself.In short, in its current form, the test appears to not make too much sense. As the test recently started failing, let's just delete it.
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.