fix(tests): Don't assume release is set #4879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though we try to figure out the current release automatically if it's not provided, it can still end up being
None
. If that's the case, it won't be attached to logs. Thetest_logs_attributes
test assumes there always is a release, which is incorrect.I opted for conditionally checking for
sentry.release
in the test instead of removing the check altogether, even though the test itself is supposed to test custom user provided attributes. The reason is that there is no other generic logs test testingsentry.release
.Issues
Closes #4878
Reminders
tox -e linters
.feat:
,fix:
,ref:
,meta:
)