Skip to content

fix(tests): Don't assume release is set #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

fix(tests): Don't assume release is set #4879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e964133
Do not check for sentry.release in test_logs_attributes
sentrivana Oct 2, 2025
830eda4
fix: Do not assume sentry.release is set
sentrivana Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/test_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ def test_logs_attributes(sentry_init, capture_envelopes):
for k, v in attrs.items():
assert logs[0]["attributes"][k] == v
assert logs[0]["attributes"]["sentry.environment"] == "production"
assert "sentry.release" in logs[0]["attributes"]
if sentry_sdk.get_client().options.get("release") is not None:
assert "sentry.release" in logs[0]["attributes"]
assert logs[0]["attributes"]["sentry.message.parameter.my_var"] == "some value"
assert logs[0]["attributes"][SPANDATA.SERVER_ADDRESS] == "test-server"
assert logs[0]["attributes"]["sentry.sdk.name"].startswith("sentry.python")
Expand Down
Loading