Skip to content

fix(litellm): Classify embeddings correctly #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

fix(litellm): Classify embeddings correctly #4918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05589e8
fix(litellm): Classify embeddings correctly
alexander-alderman-webb Oct 13, 2025
f407e6b
fix tests
alexander-alderman-webb Oct 13, 2025
8aef418
string fix
alexander-alderman-webb Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sentry_sdk/integrations/litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,11 @@ def _input_callback(kwargs):
model = full_model
provider = "unknown"

messages = kwargs.get("messages", [])
operation = "chat" if messages else "embeddings"
call_type = kwargs.get("call_type", None)
if call_type == "embedding":
operation = "embeddings"
else:
operation = "chat"

# Start a new span/transaction
span = get_start_span_function()(
Expand All @@ -71,6 +74,7 @@ def _input_callback(kwargs):
set_data_normalized(span, SPANDATA.GEN_AI_OPERATION_NAME, operation)

# Record messages if allowed
messages = kwargs.get("messages", [])
if messages and should_send_default_pii() and integration.include_prompts:
set_data_normalized(
span, SPANDATA.GEN_AI_REQUEST_MESSAGES, messages, unpack=False
Expand Down
5 changes: 3 additions & 2 deletions tests/integrations/litellm/test_litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,15 @@ def test_embeddings_create(sentry_init, capture_events):
)
events = capture_events()

messages = [{"role": "user", "content": "Some text to test embeddings"}]
mock_response = MockEmbeddingResponse()

with start_transaction(name="litellm test"):
# For embeddings, messages would be empty
kwargs = {
"model": "text-embedding-ada-002",
"input": "Hello!",
"messages": [], # Empty for embeddings
"messages": messages,
"call_type": "embedding",
}

_input_callback(kwargs)
Expand Down