Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Dec 3, 2024

We are constantly having CI problems due to gems like psych and jruby
interacting in bad ways. We don't really need these gems in CI anway so
I'm moving them to a development group.

See jruby/jruby#7262 (comment)

#skip-changelog

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (e8566fb) to head (c58e5a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
- Coverage   98.17%   98.09%   -0.09%     
==========================================
  Files         128      128              
  Lines        4827     4825       -2     
==========================================
- Hits         4739     4733       -6     
- Misses         88       92       +4     
Components Coverage Δ
sentry-ruby 98.57% <ø> (ø)
sentry-rails 97.07% <ø> (ø)
sentry-sidekiq 95.23% <ø> (-1.74%) ⬇️
sentry-resque 92.64% <ø> (-0.22%) ⬇️
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)

see 3 files with indirect coverage changes

We are constantly having CI problems due to gems like psych and jruby
interacting in bad ways. We don't really need these gems in CI anway so
I'm moving them to a development group.

See jruby/jruby#7262 (comment)
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-delayed-job-ci branch from 6d882e2 to c58e5a8 Compare December 3, 2024 14:44
@sl0thentr0py sl0thentr0py changed the title Remove psych pin for delayed_job Move dev gems to development group Dec 3, 2024
@sl0thentr0py sl0thentr0py requested review from solnic and st0012 December 3, 2024 14:45
@sl0thentr0py
Copy link
Member Author

something funny with the github caches, deleting and trying again

@sl0thentr0py
Copy link
Member Author

nvm this doesn't really help with rails anyway

@sl0thentr0py sl0thentr0py deleted the neel/fix-delayed-job-ci branch December 4, 2024 14:02
@solnic
Copy link
Collaborator

solnic commented Dec 5, 2024

@sl0thentr0py ICYM it's now possible to do gh cache delete --all - sometimes GA caches get in the way and you gotta delete them all 🤷🏻

@sl0thentr0py
Copy link
Member Author

yep i did that earlier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants