Skip to content

Move dev gems to development group #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sl0thentr0py wants to merge 1 commit into from
Closed

Move dev gems to development group #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sentry_delayed_job_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-delayed_job/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sentry_opentelemetry_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-opentelemetry/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
OPENTELEMETRY_VERSION: ${{ matrix.opentelemetry_version }}
strategy:
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sentry_rails_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-rails/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
RAILS_VERSION: ${{ matrix.rails_version }}
strategy:
fail-fast: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sentry_resque_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-resque/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Run specs without Rails
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
run: BUNDLE_WITHOUT="rubocop rails" bundle exec rake
run: BUNDLE_WITHOUT="development rails" bundle exec rake

- name: Run specs with Rails
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sentry_ruby_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-ruby/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
RACK_VERSION: ${{ matrix.rack_version }}
REDIS_RB_VERSION: ${{ matrix.redis_rb_version }}
strategy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sentry_sidekiq_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-sidekiq/Gemfile
BUNDLE_WITHOUT: rubocop
BUNDLE_WITHOUT: development
SIDEKIQ_VERSION: ${{ matrix.sidekiq_version }}
strategy:
fail-fast: false
Expand Down
20 changes: 10 additions & 10 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ git_source(:github) { |name| "https://github.com/#{name}.git" }

gem "rake", "~> 12.0"

ruby_version = Gem::Version.new(RUBY_VERSION)

# Development tools
if ruby_version >= Gem::Version.new("2.7.0")
gem "debug", github: "ruby/debug", platform: :ruby
gem "irb"
gem "ruby-lsp-rspec" if ruby_version >= Gem::Version.new("3.0.0") && RUBY_PLATFORM != "java"
end

# For RSpec
gem "rspec", "~> 3.0"
gem "rspec-retry"
gem "simplecov"
gem "simplecov-cobertura", "~> 1.4"
gem "rexml"

group :rubocop do
group :development do
ruby_version = Gem::Version.new(RUBY_VERSION)

# Development tools
if ruby_version >= Gem::Version.new("2.7.0")
gem "debug", github: "ruby/debug", platform: :ruby
gem "irb"
gem "ruby-lsp-rspec" if ruby_version >= Gem::Version.new("3.0.0") && RUBY_PLATFORM != "java"
end

gem "rubocop-rails-omakase"
gem "rubocop-packaging"
end
3 changes: 0 additions & 3 deletions sentry-delayed_job/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ gemspec
gem "sentry-ruby", path: "../sentry-ruby"
gem "sentry-rails", path: "../sentry-rails"

# For https://github.com/ruby/psych/issues/655
gem "psych", "5.1.0"

gem "delayed_job"
gem "delayed_job_active_record"

Expand Down
Loading