fix: Handle nested attributes in LogEvent to support Rails ActionController params #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
requested changes
Nov 28, 2025
| Integer => "integer", | ||
| Float => "double" | ||
| }).freeze | ||
|
|
Collaborator
There was a problem hiding this comment.
Please don't remove this, it was a performance optimization.
Author
There was a problem hiding this comment.
Thanks for the context, Could you clarify how the previous approach was improving performance?
That'll help me re-implement it correctly OR if you have a recommended approach that preserves performance, I'm happy to follow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2801.
Sentry::LogEventdoes not correctly handle nested attributes (such as Rails ActionController's params)