Skip to content

fix: Handle nested attributes in LogEvent to support Rails ActionController params #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekmiyani wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Handle nested attributes in LogEvent to support Rails ActionController params #2803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions sentry-ruby/lib/sentry/log_event.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# frozen_string_literal: true

require "json"

module Sentry
# Event type that represents a log entry with its attributes
#
Expand Down Expand Up @@ -62,13 +64,6 @@ class LogEvent
user_email
].map { |name| [name, :"serialize_#{name}"] }.to_h

VALUE_TYPES = Hash.new("string").merge!({
TrueClass => "boolean",
FalseClass => "boolean",
Integer => "integer",
Float => "double"
}).freeze

Copy link
Collaborator

@solnic solnic Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this, it was a performance optimization.

Copy link
Author

@vivekmiyani vivekmiyani Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context, Could you clarify how the previous approach was improving performance?

That'll help me re-implement it correctly OR if you have a recommended approach that preserves performance, I'm happy to follow it.

TOKEN_REGEXP = /%\{(\w+)\}/

def initialize(configuration: Sentry.configuration, **options)
Expand Down Expand Up @@ -178,11 +173,22 @@ def serialize_attributes
end

def attribute_hash(value)
{ value: value, type: value_type(value) }
end

def value_type(value)
VALUE_TYPES[value.class]
case value
when String
{ value: value, type: "string" }
when TrueClass, FalseClass
{ value: value, type: "boolean" }
when Integer
{ value: value, type: "integer" }
when Float
{ value: value, type: "double" }
else
begin
{ value: JSON.generate(value), type: "string" }
rescue
{ value: value, type: "string" }
end
end
end

def parameters
Expand Down
Loading