-
-
Notifications
You must be signed in to change notification settings - Fork 77
ci(release): Switch from action-prepare-release to Craft #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
457657c
ci(release): Switch from action-prepare-release to Craft
BYK 3f083b5
ci(release): Restore GitHub App token authentication
BYK ef35d36
fix: Pin actions to SHA and add permissions blocks
BYK 3c21d28
fix: Use correct action version SHAs (restore original versions)
BYK fb58376
fix: Use correct action version SHAs (restore original versions)
BYK f81f045
fix: Restore missing setup steps (Node.js/uv/Rust/pnpm)
BYK 99131d2
fix: Clean up action version comments
BYK 4ae79d7
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK 5be213a
Add explicit permissions block to build.yml
BYK dc8b381
Add explicit permissions block to codeql-analysis.yml
BYK ed8da68
Revert permissions changes to build.yml
BYK 2a556cf
Revert permissions changes to codeql-analysis.yml
BYK 394543e
fix: clean up release.yml formatting and version comments
BYK 3f326ab
build(craft): Update Craft action to c6e2f04
BYK 51f186d
Apply suggestion from @BYK
BYK 1fcd80e
chore: add unlabeled trigger to changelog-preview
BYK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,9 +20,9 @@ jobs: | |
| APPLE_CERT_PATH: /tmp/certs.p12 | ||
| APPLE_API_KEY_PATH: /tmp/apple_key.json | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 # v2 | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| cache: 'yarn' | ||
|
|
@@ -74,9 +74,9 @@ jobs: | |
| needs: job_build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 # v2 | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| cache: 'yarn' | ||
|
|
@@ -96,9 +96,9 @@ jobs: | |
| - ubuntu-latest | ||
| - macos-15 # We need to use macos-15 to test with Xcode 16 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 # v2 | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| node-version: ${{ matrix.node }} | ||
|
|
@@ -146,9 +146,9 @@ jobs: | |
| outputs: | ||
| wizards: ${{ steps.generate-matrix.outputs.wizards }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 # v2 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: 'yarn' | ||
|
|
@@ -176,13 +176,13 @@ jobs: | |
| SENTRY_TEST_ORG: 'sentry-javascript-sdks' | ||
| SENTRY_TEST_PROJECT: 'sentry-wizard-e2e-tests' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 # v2 | ||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # [email protected] | ||
| with: | ||
| version: 10 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: 'yarn' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.