chore(otlp): Remove span link feature flag declaration #101207
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
442
to
443
| # Enable feature to use trace tabs layout ui | ||
| manager.add("organizations:trace-tabs-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) |
There was a problem hiding this comment.
Potential bug: Removal of a backend feature flag breaks a frontend feature that depends on it.
-
Description: The removal of the
organizations:trace-view-span-linksfeature flag from the backend registration will cause a functional regression. The frontend code still checks for this flag to render theTraceSpanLinkscomponent. As the flag will be removed, the condition will always be false, preventing the component from rendering and thus disabling the span links feature for all users. -
Suggested fix: Either re-add the feature flag to the backend or remove the conditional check in the frontend code to make the feature permanently available.
severity: 0.9, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag usage removed recently.