Skip to content

chore(otlp): Remove span link feature flag declaration #101207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −2
Open

chore(otlp): Remove span link feature flag declaration #101207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:trace-spans-format", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable feature to use trace admin ui.
manager.add("organizations:trace-view-admin-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable displaying span links in the attribute tree
manager.add("organizations:trace-view-span-links", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable feature to use trace tabs layout ui
manager.add("organizations:trace-tabs-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Comment on lines 442 to 443
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Removal of a backend feature flag breaks a frontend feature that depends on it.

  • Description: The removal of the organizations:trace-view-span-links feature flag from the backend registration will cause a functional regression. The frontend code still checks for this flag to render the TraceSpanLinks component. As the flag will be removed, the condition will always be false, preventing the component from rendering and thus disabling the span links feature for all users.

  • Suggested fix: Either re-add the feature flag to the backend or remove the conditional check in the frontend code to make the feature permanently available.
    severity: 0.9, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

# Enable feature to load new traces onboarding guide.
Expand Down
Loading