ref(statistical-detectors): Hash fingerprint before generating issue group key #104033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
yuvmen
reviewed
Nov 25, 2025
| process_occurrence_data(data) | ||
| return project_id, tuple(data["fingerprint"]) | ||
| # Hash the fingerprint to match what's stored in GroupHash during issue creation | ||
| hashed_fingerprints = hash_fingerprint([fingerprint]) |
Member
There was a problem hiding this comment.
This is actually equivalent to what process_occurence_data does:
def process_occurrence_data(data: dict[str, Any]) -> None:
if "fingerprint" not in data:
return
# Hash fingerprints to make sure they're a consistent length
data["fingerprint"] = hash_fingerprint(data["fingerprint"])
So this fix would change nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-2DG5. The issue was that: Regression detector double-hashes the SHA1 fingerprint with MD5 during issue group lookup, causing a hash mismatch.
This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2822314
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.