Skip to content

ref(statistical-detectors): Hash fingerprint before generating issue group key #104033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ref(statistical-detectors): Hash fingerprint before generating issue group key #104033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/sentry/statistical_detectors/detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

from sentry import options
from sentry.api.serializers.snuba import SnubaTSResultSerializer
from sentry.issues.ingest import process_occurrence_data
from sentry.issues.ingest import hash_fingerprint
from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
from sentry.issues.status_change_consumer import bulk_get_groups_from_fingerprints
from sentry.issues.status_change_message import StatusChangeMessage
Expand Down Expand Up @@ -636,8 +636,6 @@ def generate_fingerprint(regression_type: RegressionType, name: str | int) -> st


def generate_issue_group_key(project_id: int, fingerprint: str) -> tuple[int, tuple[str, ...]]:
data = {
"fingerprint": [fingerprint],
}
process_occurrence_data(data)
return project_id, tuple(data["fingerprint"])
# Hash the fingerprint to match what's stored in GroupHash during issue creation
hashed_fingerprints = hash_fingerprint([fingerprint])
Copy link
Member

@yuvmen yuvmen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually equivalent to what process_occurence_data does:

def process_occurrence_data(data: dict[str, Any]) -> None:
    if "fingerprint" not in data:
        return

    # Hash fingerprints to make sure they're a consistent length
    data["fingerprint"] = hash_fingerprint(data["fingerprint"])

So this fix would change nothing

return project_id, tuple(hashed_fingerprints)
Loading