Skip to content

Conversation

@jerryzhou196
Copy link
Contributor

@jerryzhou196 jerryzhou196 commented Dec 2, 2025

Related to REPLAY-814: Implement new UI for Replay Page

Depends on #104247

This updates the bottom bar to

  • Reuse the ReplaySessionColumn
  • Resizes placeholder spaces accordingly

Old:
image

New:
image
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
12741 2 12739 10
View the top 2 failed test(s) by shortest run time
replayDetailsUserBadge should hide LIVE badge when last received segment is more than 5 minutes ago
Stack Traces | 0.054s run time
Error: expect(received).toBeVisible()

received value must be an HTMLElement or an SVGElement.
Received has value: null
    at __EXTERNAL_MATCHER_TRAP__ (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2237:22)
    at Object.throwingMatcher [as toBeVisible] (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2238:6)
    at Object.toBeVisible (.../detail/header/replayDetailsUserBadge.spec.tsx:305:48)
replayDetailsUserBadge should show LIVE badge when last received segment is within 5 minutes
Stack Traces | 0.07s run time
Error: expect(received).toBeVisible()

received value must be an HTMLElement or an SVGElement.
Received has value: null
    at __EXTERNAL_MATCHER_TRAP__ (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2237:22)
    at Object.throwingMatcher [as toBeVisible] (.../sentry/node_modules/.pnpm/[email protected]..../expect/build/index.js:2238:6)
    at Object.toBeVisible (.../detail/header/replayDetailsUserBadge.spec.tsx:238:48)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@linear
Copy link

linear bot commented Dec 2, 2025

jerryzhou196 added a commit that referenced this pull request Dec 2, 2025
…ation (#104247)

> Related to [REPLAY-814: Implement new UI for Replay
Page](https://linear.app/getsentry/issue/REPLAY-814/implement-new-ui-for-replay-page)

Change columns to support generic link objects. This is used in #104246
to maintain the user email search feature.
@jerryzhou196 jerryzhou196 marked this pull request as ready for review December 11, 2025 01:45
@jerryzhou196 jerryzhou196 requested a review from a team as a code owner December 11, 2025 01:45
Copy link
Contributor

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCR-20251211-koxg

with the new styling, it's less obvious that the header is a link (to the search) -- does this matter?

@jerryzhou196
Copy link
Contributor Author

SCR-20251211-koxg with the new styling, it's less obvious that the header is a link (to the search) -- does this matter?

@billyvg, thoughts?

@billyvg
Copy link
Member

billyvg commented Dec 17, 2025

SCR-20251211-koxg with the new styling, it's less obvious that the header is a link (to the search) -- does this matter?

@billyvg, thoughts?

Yeah I think that's fine, we will take what the standard components gives us (design wise)

@jerryzhou196
Copy link
Contributor Author

@billyvg okay, instead of removing referrer_table, i added some logic to check if we're on the details page, and set it to 'details' instead of 'main':

code:

referrer_table: referrer === '/explore/replays/:replaySlug/' ? 'details' : 'main',

@billyvg billyvg requested review from a team as code owners December 19, 2025 16:44
@billyvg billyvg requested a review from ryan953 December 19, 2025 16:51
@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Dec 22, 2025
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 5, 2026
@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 5, 2026
@billyvg billyvg force-pushed the new-replay-ui-3-shrink-bottom-header-4 branch from 606d039 to 9915491 Compare January 5, 2026 19:32
@billyvg billyvg force-pushed the new-replay-ui-3-shrink-bottom-header-4 branch from ca162d0 to a1af845 Compare January 6, 2026 14:40
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@billyvg billyvg added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 6, 2026
@billyvg billyvg merged commit 5758781 into master Jan 6, 2026
53 of 54 checks passed
@billyvg billyvg deleted the new-replay-ui-3-shrink-bottom-header-4 branch January 6, 2026 19:01
billyvg added a commit that referenced this pull request Jan 7, 2026
The new design changes werent that major so we are removing this flag.
(usage was removed in #104246,
flag removed in
getsentry/sentry-options-automator#6052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants