-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(replays): further reduce header size #104246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…ation (#104247) > Related to [REPLAY-814: Implement new UI for Replay Page](https://linear.app/getsentry/issue/REPLAY-814/implement-new-ui-for-replay-page) Change columns to support generic link objects. This is used in #104246 to maintain the user email search feature.
static/app/views/replays/detail/header/replayDetailsUserBadge.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billyvg, thoughts? |
Yeah I think that's fine, we will take what the standard components gives us (design wise) |
|
@billyvg okay, instead of removing code:
|
606d039 to
9915491
Compare
This reverts commit bf2f055.
ca162d0 to
a1af845
Compare
static/app/views/replays/detail/header/replayDetailsUserBadge.spec.tsx
Outdated
Show resolved
Hide resolved
The new design changes werent that major so we are removing this flag. (usage was removed in #104246, flag removed in getsentry/sentry-options-automator#6052)


Depends on #104247
This updates the bottom bar to
Old:

New:

