refactor(replay): update replay components to use linkQuery for navigation#104247
Merged
jerryzhou196 merged 2 commits intomasterfrom Dec 2, 2025
Merged
refactor(replay): update replay components to use linkQuery for navigation#104247jerryzhou196 merged 2 commits intomasterfrom
jerryzhou196 merged 2 commits intomasterfrom
Conversation
…ation Modified ReplayPreviewPlayer and ReplayTable components to utilize linkQuery for constructing navigation paths. This change enhances the clarity of the code and ensures consistent handling of query parameters across replay-related components.
github-actions
bot
added
the
Scope: Frontend
Contributor
Author
|
Tested links for:
|
billyvg
reviewed
Dec 2, 2025
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
why is this change needed? couldn't you pass query to the component?
Contributor
Author
|
The old |
Refactored ReplayPreviewPlayer and ReplayTable components to replace 'linkQuery' with 'to' for constructing navigation paths. This change improves code consistency and aligns with recent updates in replay-related components.
billyvg
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change columns to support generic link objects. This is used in #104246 to maintain the user email search feature.