DNM: Size issues e2e demo #104698
DNM: Size issues e2e demo #104698
Conversation
chromy
commented
Dec 10, 2025
chromy
commented
- feat(preprod): Add empty preprod settings page
- feat(preprod): Link settings page from build{List,Details}
- DNM: Size Issues e2e demo
This is a 'project' settings page behind the organizations:preprod-issues flag. In future it will host the settings for e.g. size analysis issue configuration and similar.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| def build(self) -> tuple[IssueOccurrence, dict[str, Any]]: | ||
| id = uuid4() | ||
| assert self.issue_title is not None, "issue_title must be set" | ||
| assert self.issue_title is not None, "issue_subtitle must be set" |
There was a problem hiding this comment.
Bug: Wrong variable checked in assertion for issue_subtitle
The assertion on line 19 checks self.issue_title is not None but the error message says "issue_subtitle must be set". This copy-paste error means issue_subtitle is never validated, so it could be None when passed to IssueOccurrence(subtitle=self.issue_subtitle, ...), potentially causing unexpected behavior or errors downstream.
| occurrence=occurrence, | ||
| event_data=event_data, | ||
| ) | ||
| logger.warning("!!!! done") |
There was a problem hiding this comment.
Bug: Debug logging statements accidentally committed to production code
Several logger.warning calls with !!!! markers appear to be debug logging statements that were accidentally included. These include messages like "!!!!!!!!!!!!!!!!? issue threshold", "!!!! trigger issue", and "!!!! done" which are not suitable for production logging and will clutter logs.
| issue_title=self.issue_title, | ||
| subtitle=self.issue_subtitle, | ||
| project_id=self.project_id, | ||
| fingerprint=uuid4().hex, |
There was a problem hiding this comment.
Bug: Fingerprint passed as string instead of list
The fingerprint parameter is passed as a single string uuid4().hex, but IssueOccurrence expects fingerprint to be a Sequence[str] (a list of strings). All other usages in the codebase pass a list like fingerprint=[...]. This type mismatch will cause issues when the fingerprint is processed downstream.
| "head_artifact_id": self.head_artifact_id, | ||
| "base_artifact_id": self.base_artifact_id, | ||
| }, | ||
| evidence_display={}, |
There was a problem hiding this comment.
Bug: Evidence display passed as dict instead of list
The evidence_display parameter is passed as an empty dict {}, but IssueOccurrence expects Sequence[IssueEvidence]. All other usages in the codebase pass an empty list [] when no evidence display is needed. This type mismatch could cause runtime errors when iterating over evidence display.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
