DNM: Size issues e2e demo #104698
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| from collections.abc import Iterator | ||
| from datetime import datetime, timezone | ||
| from typing import Any | ||
| from uuid import uuid4 | ||
|
|
||
| from sentry.issues.grouptype import PreprodDeltaGroupType | ||
| from sentry.issues.issue_occurrence import IssueOccurrence | ||
|
|
||
|
|
||
| class SizeRegressionOccurrenceBuilder: | ||
| def __init__(self): | ||
| self.issue_title = None | ||
| self.issue_subtitle = None | ||
| self.project_id = None | ||
|
|
||
| def build(self) -> tuple[IssueOccurrence, dict[str, Any]]: | ||
| id = uuid4() | ||
| assert self.issue_title is not None, "issue_title must be set" | ||
| assert self.issue_title is not None, "issue_subtitle must be set" | ||
| assert self.project_id is not None, "project_id must be set" | ||
|
|
||
| current_timestamp = datetime.now(timezone.utc) | ||
| id = uuid4().hex | ||
| event_id = uuid4().hex | ||
|
|
||
| event_data = { | ||
| "event_id": event_id, | ||
| "platform": "other", | ||
| "project_id": self.project_id, | ||
| "received": current_timestamp.isoformat(), | ||
| "sdk": None, | ||
| "tags": {}, | ||
| "timestamp": current_timestamp.isoformat(), | ||
| "environment": "prod", | ||
| } | ||
|
|
||
| return ( | ||
| IssueOccurrence( | ||
| id=id, | ||
| event_id=event_id, | ||
| issue_title=self.issue_title, | ||
| subtitle=self.issue_subtitle, | ||
| project_id=self.project_id, | ||
| fingerprint=uuid4().hex, | ||
|
Contributor
There was a problem hiding this comment. Bug: Fingerprint passed as string instead of listThe |
||
| type=PreprodDeltaGroupType, | ||
| detection_time=current_timestamp, | ||
| level="error", | ||
| resource_id="", | ||
| evidence_data={ | ||
| "head_install_size_bytes": self.head_install_size_bytes, | ||
| "base_install_size_bytes": self.base_install_size_bytes, | ||
| "head_artifact_id": self.head_artifact_id, | ||
| "base_artifact_id": self.base_artifact_id, | ||
| }, | ||
| evidence_display={}, | ||
|
Contributor
There was a problem hiding this comment. Bug: Evidence display passed as dict instead of listThe |
||
| culprit="", | ||
| ), | ||
| event_data, | ||
| ) | ||
|
|
||
|
|
||
| # from sentry.issues.grouptype import PreprodStaticGroupType | ||
| # class PreprodStaticIssueOccurrenceBuilder: | ||
| # def __init__(self): | ||
| # self.issue_title = None | ||
| # self.project_id = None | ||
| # | ||
| # def build(self) -> tuple[IssueOccurrence, dict[str, Any]]: | ||
| # id = uuid4() | ||
| # assert self.issue_title is not None, "issue_title must be set" | ||
| # assert self.project_id is not None, "project_id must be set" | ||
| # | ||
| # current_timestamp = datetime.now(timezone.utc) | ||
| # id = uuid4().hex | ||
| # event_id = uuid4().hex | ||
| # | ||
| # event_data = { | ||
| # "event_id": event_id, | ||
| # "platform": "other", | ||
| # "project_id": self.project_id, | ||
| # "received": current_timestamp.isoformat(), | ||
| # "sdk": None, | ||
| # "tags": {}, | ||
| # "timestamp": current_timestamp.isoformat(), | ||
| # # "contexts": {"monitor": get_monitor_environment_context(monitor_env)}, | ||
| # "environment": "prod", | ||
| # # "fingerprint": [incident.grouphash], | ||
| # } | ||
| # | ||
| # return ( | ||
| # IssueOccurrence( | ||
| # id=id, | ||
| # event_id=event_id, | ||
| # issue_title=self.issue_title, | ||
| # subtitle="", | ||
| # project_id=self.project_id, | ||
| # # TODO: fix | ||
| # fingerprint=uuid4().hex, | ||
| # type=PreprodStaticIssueOccurrenceBuilder, | ||
| # # Now? | ||
| # detection_time=current_timestamp, | ||
| # level="error", | ||
| # resource_id="", | ||
| # evidence_data={}, | ||
| # evidence_display={}, | ||
| # culprit="", | ||
| # ), | ||
| # event_data, | ||
| # ) | ||
| # def insight_to_occurrences(name: str, insight: dict[str, any]) -> list[SizeIssueOccurrenceBuilder]: | ||
| # builder = SizeIssueOccurrenceBuilder() | ||
| # builder.issue_title = f"Bad size {name}" | ||
| # return [builder] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import {Fragment} from 'react'; | ||
|
|
||
| import TextBlock from 'sentry/views/settings/components/text/textBlock'; | ||
| import Feature from 'sentry/components/acl/feature'; | ||
| import {ButtonBar} from 'sentry/components/core/button/buttonBar'; | ||
| import FeedbackButton from 'sentry/components/feedbackButton/feedbackButton'; | ||
| import SentryDocumentTitle from 'sentry/components/sentryDocumentTitle'; | ||
| import {t} from 'sentry/locale'; | ||
| import ProjectsStore from 'sentry/stores/projectsStore'; | ||
| import SettingsPageHeader from 'sentry/views/settings/components/settingsPageHeader'; | ||
| import {useProjectSettingsOutlet} from 'sentry/views/settings/project/projectSettingsLayout'; | ||
| import Access from 'sentry/components/acl/access'; | ||
| import {ProjectPermissionAlert} from 'sentry/views/settings/project/projectPermissionAlert'; | ||
| import Form from 'sentry/components/forms/form'; | ||
| import JsonForm from 'sentry/components/forms/jsonForm'; | ||
| import useOrganization from 'sentry/utils/useOrganization'; | ||
| import type {JsonFormObject} from 'sentry/components/forms/types'; | ||
|
|
||
| const scopeForEdit = 'project:write'; | ||
|
|
||
|
|
||
| //const defaultInstallSizeAbsoluteDeltaIssueThresholdKb = 500; | ||
|
|
||
| export default function PreprodSettings() { | ||
| const organization = useOrganization(); | ||
| const {project} = useProjectSettingsOutlet(); | ||
|
|
||
| const formGroups: JsonFormObject[] = [ | ||
| { | ||
| title: t('Size Analysis Issues'), | ||
| fields: [ | ||
| { | ||
| name: 'sentry:preprod_size_issues_is_16kb_ready', | ||
| type: 'boolean', | ||
| label: t('Create 16kb ready issues'), | ||
| help: t('Toggles whether or not to create issues for 16kb readiness.'), | ||
| getData: data => ({options: data}), | ||
| }, | ||
| { | ||
| name: 'sentry:preprod_size_issues_delta_install_threshhold_kb', | ||
| type: 'number', | ||
| label: t('Install size regression threshold (kb)'), | ||
| help: t('If there is an regression in install size larger than the threshold an issue will be created.'), | ||
| getData: data => ({options: data}), | ||
| }, | ||
| ], | ||
| }, | ||
| ]; | ||
|
|
||
| return ( | ||
| <Fragment> | ||
| <Feature features="organizations:preprod-issues" renderDisabled> | ||
| <SentryDocumentTitle title={t('Preprod')} /> | ||
| <SettingsPageHeader | ||
| title={t('Preprod')} | ||
| action={ | ||
| <ButtonBar gap="lg"> | ||
| <FeedbackButton /> | ||
| </ButtonBar> | ||
| } | ||
| /> | ||
| <Access access={[scopeForEdit]} project={project}> | ||
| {({hasAccess}) => ( | ||
| <Fragment> | ||
| <TextBlock> | ||
| {t(` | ||
| Configure size analysis and build distribution. | ||
| `)} | ||
| </TextBlock> | ||
|
|
||
| <ProjectPermissionAlert access={[scopeForEdit]} project={project} /> | ||
|
|
||
| <Form | ||
| saveOnBlur | ||
| apiMethod="PUT" | ||
| apiEndpoint={`/projects/${organization.slug}/${project.slug}/`} | ||
| initialData={project.options} | ||
| onSubmitSuccess={(response) => ProjectsStore.onUpdateSuccess(response)} | ||
| > | ||
| <JsonForm | ||
| disabled={!hasAccess} | ||
| features={new Set(organization.features)} | ||
| forms={formGroups} | ||
| /> | ||
| </Form> | ||
|
|
||
| </Fragment> | ||
| )} | ||
| </Access> | ||
| </Feature> | ||
| </Fragment> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Wrong variable checked in assertion for issue_subtitle
The assertion on line 19 checks
self.issue_title is not Nonebut the error message says "issue_subtitle must be set". This copy-paste error meansissue_subtitleis never validated, so it could beNonewhen passed toIssueOccurrence(subtitle=self.issue_subtitle, ...), potentially causing unexpected behavior or errors downstream.