fix(aci): Use notification_uuid from WorkflowFireHistory when sending notifications#105471
Merged
fix(aci): Use notification_uuid from WorkflowFireHistory when sending notifications#105471
Conversation
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Dec 29, 2025
Contributor
cathteng
left a comment
cathteng
left a comment
There was a problem hiding this comment.
Wow this goes down so many levels
| return TargetTypeConfigTransformer.from_config_schema(DiscordActionHandler.config_schema) | ||
|
|
||
| @staticmethod | ||
| @override |
Contributor
There was a problem hiding this comment.
If ActionHandler.execute was an ABC with execute as an abstractmethod, would we need the override?
Member
Author
There was a problem hiding this comment.
I'm pretty sure it'll complain if you try to instantiate a class with no implementation of an abstract method.
override goes the other way, in that it'll complain if you've applied it to a method that doesn't have a matching parent class method.
So, maybe both have value?
Member
Author
|
Decided it might be better to do #105524 first, making this change much more reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When investigating links sent via notification, we usually have access to the notification_uuid url param which is unique per notification.
To make this useful, we thread through the notification_uuid from WorkflowFireHistory, which was previously unused, to make it easy to associate with a history entry and thus a workflow/group/etc.