-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(projects): warn about eventual removal of Project Details #105617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DominikB2014
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm overall, but i think we should fix the linking issue before merging
| initialRouterConfig, | ||
| }); | ||
|
|
||
| expect(await screen.findByText(/similar charts are available/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually try to use something more elegant instead of finding text directly, but for a temporary banner this is more then enough imo 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikB2014 for future reference, what helper do you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We like to use getByRole where possible
cf62857 to
b031a3c
Compare
Co-authored-by: Dominik Buszowiecki <[email protected]>
4894b6e to
3db1160
Compare
Project Details
Project LIst
We're considering removing the Project Pages. These pages serve a few purposes that are redundant:
TODO: