-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(projects): warn about eventual removal of Project Details #105617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ import * as pageFilters from 'sentry/actionCreators/pageFilters'; | |
| import ProjectsStore from 'sentry/stores/projectsStore'; | ||
|
|
||
| import ProjectDetail from './projectDetail'; | ||
| import ProjectDetailContainer from './'; | ||
|
|
||
| jest.mock('sentry/actionCreators/organization'); | ||
|
|
||
|
|
@@ -112,6 +113,18 @@ describe('ProjectDetail', () => { | |
| expect(screen.getByText(project.slug)).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('Render deprecation dialog', async () => { | ||
| ProjectsStore.loadInitialData([project]); | ||
| setupMockResponses(); | ||
|
|
||
| render(<ProjectDetailContainer />, { | ||
| organization, | ||
| initialRouterConfig, | ||
| }); | ||
|
|
||
| expect(await screen.findByText(/similar charts are available/i)).toBeInTheDocument(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We usually try to use something more elegant instead of finding text directly, but for a temporary banner this is more then enough imo 👍
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DominikB2014 for future reference, what helper do you suggest?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We like to use getByRole where possible |
||
| }); | ||
|
|
||
| it('Sync project with slug', async () => { | ||
| ProjectsStore.loadInitialData([project]); | ||
| setupMockResponses(); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.