build(ui): Consolidate tsconfig files #106034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need tsconfig files, i think these are mostly from when we were moving the app to typescript
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
scttcper
commented
Jan 9, 2026
Comment on lines
47
to
48
| "allowJs": true, | ||
| "checkJs": true, |
Member
Author
There was a problem hiding this comment.
keeping these enabled like we had before
scttcper
commented
Jan 9, 2026
| "checkJs": true, | ||
|
|
||
| "esModuleInterop": true, | ||
| "experimentalDecorators": false, |
Member
Author
There was a problem hiding this comment.
turned off experimental decorators since i think we might have been using them at some point, but we aren't anymore
scttcper
added a commit
that referenced
this pull request
Jan 9, 2026
Adds the typescript (tsgo) nightly native preview https://github.com/microsoft/typescript-go We could continue to adopt this and run it as the typechecker in our github actions. Adds a comment in static/AGENTS.md that should point claude code to the right command related tsconfig consolidation #106034
natemoo-re
approved these changes
Jan 12, 2026
scttcper
added a commit
that referenced
this pull request
Jan 13, 2026
Saves about 1gb of memory when actively typechecking. After consolidating tsconfigs in #106034 we were typechecking more files. This reverts the fork-ts-typechecker plugin to the original behavior.
scttcper
added a commit
that referenced
this pull request
Jan 13, 2026
Saves about 1gb of memory when actively typechecking. After consolidating tsconfigs in #106034 we were typechecking more files. This reverts the fork-ts-typechecker plugin to the original behavior. reminder that you can always turn this off and save a bunch of cpu/memory with `NO_TS_FORK=1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidates tsconfig files that i think we left hanging around after finishing migrating to typescript. I don't think the complexity of having 3 tsconfigs is worth whatever slight speed increase we see from not typechecking a subset of files. rspack config can be setup to exclude tests if we need to exclude them there
merges root tsconfig with
tsconfig.base.jsonand also: