Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .vercelignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
!stylelint.config.js
!tsconfig.json
!config
!config/tsconfig.build.json
!webpack.config.js
!pnpm-lock.yaml
!tests
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ test-cli: create-db

test-js-build:
@echo "--> Running type check"
@pnpm run tsc -p config/tsconfig.build.json
@pnpm run tsc -p tsconfig.json
@echo "--> Building static assets"
@NODE_ENV=production pnpm run build-profile > .artifacts/webpack-stats.json

Expand Down
122 changes: 0 additions & 122 deletions config/tsconfig.base.json

This file was deleted.

12 changes: 0 additions & 12 deletions config/tsconfig.build.json

This file was deleted.

5 changes: 0 additions & 5 deletions config/tsconfig.ci.json

This file was deleted.

5 changes: 1 addition & 4 deletions rspack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -453,10 +453,7 @@ const appConfig: Configuration = {
? [
new TsCheckerRspackPlugin({
typescript: {
configFile: path.resolve(
import.meta.dirname,
'./config/tsconfig.build.json'
),
configFile: path.resolve(import.meta.dirname, './tsconfig.json'),
},
devServer: false,
}),
Expand Down
80 changes: 78 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,83 @@
{
"extends": "./config/tsconfig.base.json",
"$schema": "http://json.schemastore.org/tsconfig",

"compilerOptions": {
// NOTE: We DO NOT use typescript to compile the application. SWC is
// responsible for handing transformation of tsx files into plain JavaScript
"module": "preserve",
"target": "ES2022",
"moduleResolution": "bundler",

// We add esnext to lib to pull in types for all newer ECMAScript features
"lib": ["esnext", "dom", "dom.iterable"],

// Skip type checking of all declaration files
"skipLibCheck": true,

// We do not actually use tsc to output any JavaScript anywhere
"noEmit": true,

// Don't do anything to JSX. This doesn't really matter since we don't use
// typescript to compile files, but left here for documentation purposes.
"jsx": "preserve",
"jsxImportSource": "@emotion/react",

// Type checking specific options
"alwaysStrict": false,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noUncheckedIndexedAccess": true,
"strict": true,
"strictBindCallApply": false,
"useUnknownInCatchVariables": true,

// Emit configuration
"declaration": false,
"declarationMap": false,
"downlevelIteration": true,
"importHelpers": true,
"inlineSources": false,
"noEmitHelpers": true,
"sourceMap": true,
"pretty": false,
"allowJs": true,
"checkJs": true,
Comment on lines 47 to 48
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping these enabled like we had before


"esModuleInterop": true,
"experimentalDecorators": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turned off experimental decorators since i think we might have been using them at some point, but we aren't anymore

"resolveJsonModule": true,
"verbatimModuleSyntax": true,

"paths": {
"@sentry/scraps/*": ["./static/app/components/core/*"],
"sentry/*": ["./static/app/*"],
"sentry-fixture/*": ["./tests/js/fixtures/*"],
"sentry-test/*": ["./tests/js/sentry-test/*"],
"getsentry-test/*": ["./tests/js/getsentry-test/*"],
"sentry-images/*": ["./static/images/*"],
"sentry-locale/*": ["./src/sentry/locale/*"],
"sentry-logos/*": ["./src/sentry/static/sentry/images/logos/*"],
"sentry-fonts/*": ["./static/fonts/*"],
"getsentry/*": ["./static/gsApp/*"],
"getsentry-images/*": ["./static/images/*"],
"admin/*": ["./static/gsAdmin/*"],
},

"plugins": [
// The styled plugin provides language server autocompletion for styled
// component template strings
{
"name": "@styled/typescript-styled-plugin",
"lint": {
"validProperties": ["container-type"],
"unknownAtRules": "ignore"
}
}
]
},
"include": [
"*.config.mjs",
Expand All @@ -14,5 +89,6 @@
"tests/js",
"config",
"scripts"
]
],
"exclude": ["./node_modules"]
}
Loading