feat(data-forwarding): add padding prop to FieldLayout components#108803
Merged
feat(data-forwarding): add padding prop to FieldLayout components#108803
Conversation
github-actions
bot
added
the
Scope: Frontend
JonasBa
force-pushed
the
jb/settings/data-forwarding-form-layout
branch
from
3ebb3d3 to
882782d
Compare
natemoo-re
approved these changes
Feb 23, 2026
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…08803) Adds an optional `padding` prop to `FieldLayout.Row` and `FieldLayout.Stack` in `static/app/components/core/form/layout/index.tsx`. Needed by the data forwarding form migration (follow-up PRs) where form fields rendered inside a `Disclosure` require padding to match the surrounding layout. Since these are layout components, I think it is reasonable for us to forward the props
wedamija
pushed a commit
that referenced
this pull request
Feb 24, 2026
…08803) Adds an optional `padding` prop to `FieldLayout.Row` and `FieldLayout.Stack` in `static/app/components/core/form/layout/index.tsx`. Needed by the data forwarding form migration (follow-up PRs) where form fields rendered inside a `Disclosure` require padding to match the surrounding layout. Since these are layout components, I think it is reasonable for us to forward the props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
paddingprop toFieldLayout.RowandFieldLayout.Stackinstatic/app/components/core/form/layout/index.tsx.Needed by the data forwarding form migration (follow-up PRs) where form fields rendered inside a
Disclosurerequire padding to match the surrounding layout.Since these are layout components, I think it is reasonable for us to forward the props