Skip to content

feat(data-forwarding): add padding prop to FieldLayout components #108803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasBa merged 1 commit into from
Feb 23, 2026
Merged

feat(data-forwarding): add padding prop to FieldLayout components #108803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions static/app/components/core/form/layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import {FieldMeta} from '@sentry/scraps/form/field/meta';
import {useFieldContext} from '@sentry/scraps/form/formContext';
import {Container, Flex, Stack} from '@sentry/scraps/layout';
import {
Container,
Flex,
Stack,
type FlexProps,
type StackProps,
} from '@sentry/scraps/layout';

interface LayoutProps {
children: React.ReactNode;
Expand All @@ -10,12 +16,22 @@ interface LayoutProps {
variant?: 'compact';
}

function RowLayout(props: LayoutProps) {
interface RowLayoutProps extends LayoutProps {
padding?: FlexProps<'div'>['padding'];
}

function RowLayout(props: RowLayoutProps) {
const isCompact = props.variant === 'compact';
const field = useFieldContext();

return (
<Flex id={field.name} gap="sm" align="center" justify="between">
<Flex
id={field.name}
gap="sm"
align="center"
justify="between"
padding={props.padding}
>
<Stack width="50%" gap="xs">
<Flex gap="xs" align="center">
<FieldMeta.Label
Expand All @@ -35,12 +51,16 @@ function RowLayout(props: LayoutProps) {
);
}

function StackLayout(props: LayoutProps) {
interface StackLayoutProps extends LayoutProps {
padding?: StackProps<'div'>['padding'];
}

function StackLayout(props: StackLayoutProps) {
const isCompact = props.variant === 'compact';
const field = useFieldContext();

return (
<Stack id={field.name} gap="md">
<Stack id={field.name} gap="md" padding={props.padding}>
<Flex gap="xs" align="center">
<FieldMeta.Label
required={props.required}
Expand Down
Loading