ref(components): convert StackedAreaChart from class to function component#109601
Open
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Open
ref(components): convert StackedAreaChart from class to function component#109601JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
force-pushed
the
function-component-stacked-area-chart
branch
from
2281a9d to
02d4a65
Compare
JoshuaKGoldberg
commented
Feb 27, 2026
| getChart(): | ||
| | React.ComponentType<StackedAreaChart['props']> | ||
| | React.ComponentType<AreaChartProps> { | ||
| getChart(): React.ComponentType<AreaChartProps> { |
Member
Author
There was a problem hiding this comment.
StackedAreaChart['props'] was AreaChartProps already! Duplicate type constituents. https://typescript-eslint.io/rules/no-duplicate-type-constituents/
JoshuaKGoldberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 5-liner. If it causes any bugs I will be amazed.